Summary: | [NEW] devel/py-future: Clean single-source support for Python 3 and 2 | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Muhammad Moinur Rahman <bofh> | ||||
Component: | Individual Port(s) | Assignee: | Kubilay Kocak <koobs> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | CC: | koobs | ||||
Priority: | --- | Keywords: | needs-patch, needs-qa | ||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
Muhammad Moinur Rahman
2014-08-28 13:44:39 UTC
Review: - Remove name and indefinite article from COMMENT [1] Suggest using the PyPi (setup.py) short description: "Clean single-source support for Python 3 and 2" - Add LICENSE_FILE where one exists in the distribution files [2] - pkg-descr WWW: https://github.com/PythonCharmers/python-future as set in setup.py (and displayed on PyPi under Homepage:) - Where they exist, attempt to integrate unit tests, that is: * Add regression-test: target @cd ${WRKSRC} && ${PYTHON_CMD} ${PYDISTUTILS_SETUP} test * Add TEST_DEPENDS for tests_requires (test dependencies) * Patch setup.py to add the test command if its doesn't already, and is easy. Send the above patch upstream (optional) [4][5][6] * Add TESTS option (optional) * Add TEST_DEPENDS to BUILD_DEPENDS if TESTS option is enabled (optional) * Add test suite results to your QA and future submissions, along with portlint, poudriere, redports, etc [1] http://www2.au.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#makefile-comment [2] https://github.com/PythonCharmers/python-future/blob/master/LICENSE.txt [3] https://github.com/PythonCharmers/python-future/blob/master/setup.py#L63 [4] https://pythonhosted.org/setuptools/setuptools.html#test-build-package-and-run-a-unittest-suite [5] http://nose.readthedocs.org/en/latest/setuptools_integration.html [6] http://pytest.org/latest/goodpractises.html#integrating-with-distutils-python-setup-py-test Pending updated patch based on above review Also, feel free to provide an svn diff rather than a shell archive, including the relevant addition to devel/Makefile A commit references this bug: Author: koobs Date: Mon Dec 22 10:59:50 UTC 2014 New revision: 375228 URL: https://svnweb.freebsd.org/changeset/ports/375228 Log: [NEW] devel/py-future: Clean single-source support for Python 3 and 2 future is the missing compatibility layer between Python 2 and Python 3. It allows you to use a single, clean Python 3.x-compatible codebase to support both Python 2 and Python 3 with minimal overhead. WWW: https://python-future.org/ PR: 193094 Submitted by: Muhammad Moinur Rahman <5u623l20 at gmail com> (with changes) Changes: head/devel/Makefile head/devel/py-future/ head/devel/py-future/Makefile head/devel/py-future/distinfo head/devel/py-future/pkg-descr Committed with changes, thanks Muhammad! |