Bug 193131

Summary: [maintainer update] www/libevhtp patch
Product: Ports & Packages Reporter: Jingfeng Yan <yan_jingfeng>
Component: Individual Port(s)Assignee: Carlo Strub <cs>
Status: Closed FIXED    
Severity: Affects Some People CC: cs, yan_jingfeng
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
URL: https://github.com/ellzey/libevhtp
Bug Depends on:    
Bug Blocks: 193134    
Attachments:
Description Flags
svn diff
none
test log
yan_jingfeng: maintainer-approval+
add port revision none

Description Jingfeng Yan 2014-08-29 19:47:51 UTC
Created attachment 146498 [details]
svn diff

(1)The update provides options on par with original lib source, except share lib part.  
(2) change static lib to be shared lib by default, which is required in my another ports.  
(3) about 8.4 release broken: the issue will be resolved by adding one include file. There is one line missing in 8.4 tcp.h file.
Comment 1 Jingfeng Yan 2014-08-29 19:48:43 UTC
Created attachment 146499 [details]
test log
Comment 2 John Marino freebsd_committer 2014-08-29 20:09:00 UTC
Okay, this needs to increment PORTREVISION for multiple reasons.  Can you update the patch to add PORTREVISION=1?  That's the only issue I see.
Comment 3 Jingfeng Yan 2014-08-29 20:46:37 UTC
Created attachment 146511 [details]
add port revision
Comment 4 John Marino freebsd_committer 2014-08-29 20:49:48 UTC
Thanks, moving to patch-ready status.
Comment 5 Jingfeng Yan 2014-08-29 20:51:36 UTC
(In reply to John Marino from comment #2)
> Okay, this needs to increment PORTREVISION for multiple reasons.  Can you
> update the patch to add PORTREVISION=1?  That's the only issue I see.

correct it and update the diff.  Rerun the test port seems to be fine.  Thank you for your quick response.
Comment 6 Jingfeng Yan 2014-08-29 20:52:14 UTC
(In reply to John Marino from comment #4)
> Thanks, moving to patch-ready status.

My hands are slower than yours. :)
Comment 7 commit-hook freebsd_committer 2014-09-05 21:23:55 UTC
A commit references this bug:

Author: cs
Date: Fri Sep  5 21:23:30 UTC 2014
New revision: 367392
URL: http://svnweb.freebsd.org/changeset/ports/367392

Log:
  - The update provides options on par with original lib source, except share lib
    part.
  - change static lib to be shared lib by default, which is required in my
    another ports.
  - about 8.4 release broken: the issue will be resolved by adding one include
    file. There is one line missing in 8.4 tcp.h file.

  PR:		193131
  Submitted by:	Jingfeng Yan (maintainer)
  MFH:		2014q3

Changes:
  head/www/libevhtp/Makefile
  head/www/libevhtp/files/
  head/www/libevhtp/files/patch-evhtp.c
Comment 8 Carlo Strub freebsd_committer 2014-09-05 21:26:46 UTC
Committed. Thank you very much.
Comment 9 Jingfeng Yan 2014-09-05 21:31:39 UTC
(In reply to Carlo Strub from comment #8)
> Committed. Thank you very much.

Thank you for your help.