Bug 193137

Summary: devel/git: Use CONFIGURE args for ICONV support, Sort pkg-plist
Product: Ports & Packages Reporter: Kubilay Kocak <koobs>
Component: Individual Port(s)Assignee: Wesley Shields <wxs>
Status: Closed Overcome By Events    
Severity: Affects Some People Keywords: needs-qa
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Update to 2.1.0, iconv w/ configure, sort pkg-plist none

Description Kubilay Kocak freebsd_committer freebsd_triage 2014-08-30 01:34:17 UTC 
Submitting patch created for user via freebsd-ports list thread [1] updating git to 2.1.0:

- Update to 2.1.0
- Sort pkg-plist (much easier to update when sorted!)
- Use CONFIGURE_ARGS user-knob to disable libiconv

There is a leftover issue (in the current version of the port too)
building *without* ICONV and *with* CONTRIB option

[1] https://lists.freebsd.org/pipermail/freebsd-ports/2014-August/094925.html
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2014-08-30 01:35:02 UTC 
Created attachment 146513 [details]
Update to 2.1.0, iconv w/ configure, sort pkg-plist
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2015-07-07 06:14:31 UTC 
This change no longer works, though I don't know when or why. I spent several hours trying to wrangle git's build system, which is one of the worst i've seen re autotools/make.

Right now the git build will find and link to libiconv even when the ICONV option is disabled. I tried all combinations of CONFIGURE_* and MAKE_* foo, including explicitly setting NEEDS_LIBICONV to ''. Using this I was able to get the build as far as utf8.c was failing with undefined gettext compilation errors.

config.mak.uname sets this variable for FreeBSD, which was patched out in past versions of the port. Removing it again doesn't change the behaviour.

It appears (at least for now) that libiconv is a compulsory requirement. I am not sure if this is a regression or not (though I believe it wasn't compulsory in the past).
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2015-07-17 06:14:47 UTC 
Wesley, the git port currently unconditionally links against libiconv, no matter how disabling it is attempted (see comment 2)

I'm going to close this PR since nothing can be done with it. However, I suggest opening a new issue (or just fixing it) to make LIBICONV non-optional until it can be properly disabled when libiconv is installed.