Bug 193148

Summary: [databases/php55-dba] patch for db6 compatibility
Product: Ports & Packages Reporter: alexander
Component: Individual Port(s)Assignee: Alex Dupre <ale>
Status: Closed Feedback Timeout    
Severity: Affects Some People CC: arved, miwi
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   

Description alexander 2014-08-30 14:41:16 UTC
databases/php55-dba currenlty does not configure with databases/db6 installed. This is due to a bug in the configure script which finds the library but in a later test fails to recognize the version (only checks for 4.8+, or 5 but misses 6):

checking for DB4 major version... configure: error: Header contains different version


This is a known issue upstream, where it is marked as won't fix due to licensing concerns. I don't know what the port policy is on this, but the upstream patch in https://bugs.php.net/bug.php?id=65426 works for me.
Comment 1 Tilman Keskinoz freebsd_committer freebsd_triage 2014-08-31 09:33:16 UTC
over to maintainer..
Comment 2 John Marino freebsd_committer freebsd_triage 2014-09-20 18:08:21 UTC
Alexander, the PR is timed out by the maintainer.
However, I'm not moving it to patch-ready since there is no patch attached.  We don't like "here's a link, go create the patch yourself" type of reports.

If you create the patch, I'll move it to patch-ready.  Or hopefully Alex (the maintainer) will take over the PR before then.
Comment 3 alexander 2014-09-22 07:29:22 UTC
John, thank you for the feedback. Unfortunately, I'm not an expert on the FreeBSD BDB infrastructure, nor on patching configure scripts. I have a local version that "works for me" but even if I submitted it, it would by no means be patch ready.
There is already a patch in the port that modifies the original configure script to catch BDB in FreeBSD specific locations as well as specific versions. I believe it is better if the original author of the patch takes a look at the issue, or someone who is familiar with how other ports in the ports tree do this.
Lastly, there is the licensing issue mentioned upstream that prompted them not to include a patch for this in their main code (BDB6 being GNU AGPL v3). As I don't know the FreeBSD policies on this issue, I think it is better this bug stays unresolved until someone with more insight into these issues finds the time to take a look.

If you disagree, please let me know and I will see if I can produce a patch based on what works for me.
Comment 4 John Marino freebsd_committer freebsd_triage 2014-09-22 07:51:02 UTC
Well, without a mature and tested patch, this PR was misclassified as "approval needed" before.  I'm going to move it to "open" which is a more accurate status.  You're basically depending on Alex to create the patch at this point.