Bug 193154

Summary: audio/gogglesmm: Update to version 0.13.3
Product: Ports & Packages Reporter: tkato432
Component: Individual Port(s)Assignee: John Marino <marino>
Status: Closed FIXED    
Severity: Affects Only Me CC: marino
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
audio_gogglesmm.diff
none
audio_gogglesmm.diff
none
audio_gogglesmm.diff none

Description tkato432 2014-08-30 18:30:54 UTC
Created attachment 146547 [details]
audio_gogglesmm.diff
Comment 1 John Marino freebsd_committer freebsd_triage 2014-08-30 20:12:23 UTC
can you resubmit with a minor change?

OSVERSION needs OPSYS

e.g.

.if ${OSVERSION} < 900000

should be

.if ${OPSYS} == FreeBSD && ${OSVERSION} < 900000



It would be best if OSVERSION wasn't needed at all.  There's no setting for USES=compiler:<opt> that works universally without checking OSVERSION?
Comment 2 tkato432 2014-08-31 12:30:07 UTC
Created attachment 146593 [details]
audio_gogglesmm.diff

> It would be best if OSVERSION wasn't needed at all.  There's no setting for
> USES=compiler:<opt> that works universally without checking OSVERSION?

 11.0-CURRENT: OK with base clang
 10.0-RELEASE: NG with base clang / Needs ports gcc47
 9.3-RELEASE: OK with base clang
 8.4-RELEASE: NG with base gcc / Nees ports clang33 (or gcc47)

The most annoying thing is base clang in 10.0, which is older and
buggier than in 9.3. In this case, using OSVERSION would be
inevitable since Uses/compiler.mk has no logic to distinguish base
clang between 10.0 and 9.3.
Comment 3 John Marino freebsd_committer freebsd_triage 2014-08-31 12:39:05 UTC
ah, a rare <options>, <pre>, <post> port

Okay, thanks for looking anyway.
Comment 4 tkato432 2014-08-31 13:10:14 UTC
Created attachment 146595 [details]
audio_gogglesmm.diff

Oh, I found out that there's a way to enable building this port
on all FreeBSD versions without using OSVERSION.
Comment 5 commit-hook freebsd_committer freebsd_triage 2014-09-16 21:49:50 UTC
A commit references this bug:

Author: marino
Date: Tue Sep 16 21:49:13 UTC 2014
New revision: 368349
URL: http://svnweb.freebsd.org/changeset/ports/368349

Log:
  audio/gogglesmm: Upgrade version 0.13.2 => 0.13.3

  PR:		193154
  Submitted by:	Ports Fury

Changes:
  head/audio/gogglesmm/Makefile
  head/audio/gogglesmm/distinfo
  head/audio/gogglesmm/files/patch-src__gap__ap_reactor.cpp
  head/audio/gogglesmm/files/patch-src__gap__ap_socket.cpp
  head/audio/gogglesmm/files/patch-src__gap__ap_utils.cpp
  head/audio/gogglesmm/files/patch-src__gap__plugins__ap_oss_plugin.cpp
Comment 6 John Marino freebsd_committer freebsd_triage 2014-09-16 21:51:14 UTC
Thanks!