Bug 19317

Summary: postgres depends on a very old version of tcl.
Product: Ports & Packages Reporter: adrian <adrian>
Component: Individual Port(s)Assignee: andreas <andreas>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description adrian 2000-06-16 01:00:03 UTC
	Ths postgres-6.5.3 port depends on tcl-8.0, when it builds
	and runs fine with 8.2.3.  Note that there did indeed seem
	to be build problems with tcl-8.2.2.  These went away with
	8.2.3.

	I did see the closed PR ports/16951 that indicated that
	there were build problems with previous patches.  I have
	no trouble building with the attached patch.  The simple
	tcl DB application that I have written works just fine.

	N.B.  While at it, I figured out what was wrong with pgaccess
	and uncommented it in the Makefile.  The problem was that
	the source file changed from a tcl script to a bourne shell
	script.

Fix: Apply this patch:
How-To-Repeat: 
	N/A
Comment 1 scrappy 2000-06-16 02:16:01 UTC
umm, didn't notice it before, but v6.5.3 shouldn't be used anymore, its
pretty much considered 'ancient history' already as far as the developers
are concerned.  I'm curious as to why there was a postgresql7 port
created seperately from the postgresql port, but I would highly recommend
using that one instead of the regular postgresql port ... faster and more
stable, with more features ...

On Thu, 15 Jun 2000 adrian@ubergeeks.com wrote:

> 
> >Number:         19317
> >Category:       ports
> >Synopsis:       postgres depends on a very old version of tcl.
> >Confidential:   no
> >Severity:       non-critical
> >Priority:       medium
> >Responsible:    freebsd-ports
> >State:          open
> >Quarter:        
> >Keywords:       
> >Date-Required:
> >Class:          change-request
> >Submitter-Id:   current-users
> >Arrival-Date:   Thu Jun 15 17:00:03 PDT 2000
> >Closed-Date:
> >Last-Modified:
> >Originator:     Adrian Filipi-Martin
> >Release:        FreeBSD 3.4-RELEASE i386
> >Organization:
> Ubergeeks Consulting
> >Environment:
> 
> 	3.4-RELEASE and 3.3-RELEASe with /usr/ports from 6/14/00.
> 
> >Description:
> 
> 	Ths postgres-6.5.3 port depends on tcl-8.0, when it builds
> 	and runs fine with 8.2.3.  Note that there did indeed seem
> 	to be build problems with tcl-8.2.2.  These went away with
> 	8.2.3.
> 
> 	I did see the closed PR ports/16951 that indicated that
> 	there were build problems with previous patches.  I have
> 	no trouble building with the attached patch.  The simple
> 	tcl DB application that I have written works just fine.
> 
> 	N.B.  While at it, I figured out what was wrong with pgaccess
> 	and uncommented it in the Makefile.  The problem was that
> 	the source file changed from a tcl script to a bourne shell
> 	script.
> 
> >How-To-Repeat:
> 
> 	N/A
> 
> >Fix:
> 	
> 	Apply this patch:
> 
> --- Makefile.orig	Fri Apr 21 07:31:17 2000
> +++ Makefile	Thu Jun 15 18:50:44 2000
> @@ -25,12 +25,12 @@
>  # if you want to use the tcl/tk frontend pgaccess, then you need to build
>  # postgresql with tcl support by typing: make WITH_TCL=yes
>  .if defined(WITH_TCL)
> -TCL_INCDIR=	${LOCALBASE}/include/tcl8.0
> -TK_INCDIR=	${LOCALBASE}/include/tk8.0
> +TCL_INCDIR=	${LOCALBASE}/include/tcl8.2
> +TK_INCDIR=	${LOCALBASE}/include/tk8.2
>  MAKE_ENV=	WITH_TCL=true TCL_INCDIR=${TCL_INCDIR}
> -LIB_DEPENDS=	tcl80.1:${PORTSDIR}/lang/tcl80 \
> -		tk80.1:${PORTSDIR}/x11-toolkits/tk80
> -CONFIGURE_TCL=	--with-tcl --with-tclconfig="${LOCALBASE}/lib/tcl8.0 ${LOCALBASE}/lib/tk8.0"
> +LIB_DEPENDS=	tcl82.1:${PORTSDIR}/lang/tcl82 \
> +		tk82.1:${PORTSDIR}/x11-toolkits/tk82
> +CONFIGURE_TCL=	--with-tcl --with-tclconfig="${LOCALBASE}/lib/tcl8.2 ${LOCALBASE}/lib/tk8.2"
>  .endif
>  
>  # if you want jdbc, type make WITH_JDBC=yes
> @@ -103,14 +103,13 @@
>  	@ ${SED} -e 's=!!PREFIX!!=${PREFIX}=g' \
>  		${WRKSRC}/Makefile.global.in.old \
>  		>> ${WRKSRC}/Makefile.global.in
> -# pgaccess (accidentally?) removed from distribution, so leave it for now
> -#.if defined(WITH_TCL)
> -#	@ ${MV} ${WRKSRC}/bin/pgaccess/pgaccess.tcl \
> -#		${WRKSRC}/bin/pgaccess/pgaccess.tcl.orig
> -#	@ ${SED} -e "s=/usr/bin/wish=`/usr/bin/which wish8.0`=" \
> -#		${WRKSRC}/bin/pgaccess/pgaccess.tcl.orig \
> -#		>> ${WRKSRC}/bin/pgaccess/pgaccess.tcl
> -#.endif
> +.if defined(WITH_TCL)
> +	@ ${MV} ${WRKSRC}/bin/pgaccess/pgaccess.sh \
> +		${WRKSRC}/bin/pgaccess/pgaccess.sh.orig
> +	@ ${SED} -e "s=__wish__=`/usr/bin/which wish8.2`=" \
> +		${WRKSRC}/bin/pgaccess/pgaccess.sh.orig \
> +		>> ${WRKSRC}/bin/pgaccess/pgaccess.sh
> +.endif
>  
>  post-build:
>  .if defined(WITH_JDBC)
> 
> 
> >Release-Note:
> >Audit-Trail:
> >Unformatted:
> 
> 
> To Unsubscribe: send mail to majordomo@FreeBSD.org
> with "unsubscribe freebsd-ports" in the body of the message
> 

Marc G. Fournier                   ICQ#7615664               IRC Nick: Scrappy
Systems Administrator @ hub.org 
primary: scrappy@hub.org           secondary: scrappy@{freebsd|postgresql}.org
Comment 2 adrian 2000-06-16 21:51:44 UTC
Things do move at a lightening speed these days, but postgres7 is only six
weeks old.  I hardly think that makes the 6.x branch ancient.  I'm sticking
with it until 7 gets a bit older.

	Adrian


On Thu, 15 Jun 2000, The Hermit Hacker wrote:

> 
> umm, didn't notice it before, but v6.5.3 shouldn't be used anymore, its
> pretty much considered 'ancient history' already as far as the developers
> are concerned.  I'm curious as to why there was a postgresql7 port
> created seperately from the postgresql port, but I would highly recommend
> using that one instead of the regular postgresql port ... faster and more
> stable, with more features ...
> 
> On Thu, 15 Jun 2000 adrian@ubergeeks.com wrote:
> 
> > 
> > >Number:         19317
> > >Category:       ports
> > >Synopsis:       postgres depends on a very old version of tcl.
> > >Confidential:   no
> > >Severity:       non-critical
> > >Priority:       medium
> > >Responsible:    freebsd-ports
> > >State:          open
> > >Quarter:        
> > >Keywords:       
> > >Date-Required:
> > >Class:          change-request
> > >Submitter-Id:   current-users
> > >Arrival-Date:   Thu Jun 15 17:00:03 PDT 2000
> > >Closed-Date:
> > >Last-Modified:
> > >Originator:     Adrian Filipi-Martin
> > >Release:        FreeBSD 3.4-RELEASE i386
> > >Organization:
> > Ubergeeks Consulting
> > >Environment:
> > 
> > 	3.4-RELEASE and 3.3-RELEASe with /usr/ports from 6/14/00.
> > 
> > >Description:
> > 
> > 	Ths postgres-6.5.3 port depends on tcl-8.0, when it builds
> > 	and runs fine with 8.2.3.  Note that there did indeed seem
> > 	to be build problems with tcl-8.2.2.  These went away with
> > 	8.2.3.
> > 
> > 	I did see the closed PR ports/16951 that indicated that
> > 	there were build problems with previous patches.  I have
> > 	no trouble building with the attached patch.  The simple
> > 	tcl DB application that I have written works just fine.
> > 
> > 	N.B.  While at it, I figured out what was wrong with pgaccess
> > 	and uncommented it in the Makefile.  The problem was that
> > 	the source file changed from a tcl script to a bourne shell
> > 	script.
> > 
> > >How-To-Repeat:
> > 
> > 	N/A
> > 
> > >Fix:
> > 	
> > 	Apply this patch:
> > 
> > --- Makefile.orig	Fri Apr 21 07:31:17 2000
> > +++ Makefile	Thu Jun 15 18:50:44 2000
> > @@ -25,12 +25,12 @@
> >  # if you want to use the tcl/tk frontend pgaccess, then you need to build
> >  # postgresql with tcl support by typing: make WITH_TCL=yes
> >  .if defined(WITH_TCL)
> > -TCL_INCDIR=	${LOCALBASE}/include/tcl8.0
> > -TK_INCDIR=	${LOCALBASE}/include/tk8.0
> > +TCL_INCDIR=	${LOCALBASE}/include/tcl8.2
> > +TK_INCDIR=	${LOCALBASE}/include/tk8.2
> >  MAKE_ENV=	WITH_TCL=true TCL_INCDIR=${TCL_INCDIR}
> > -LIB_DEPENDS=	tcl80.1:${PORTSDIR}/lang/tcl80 \
> > -		tk80.1:${PORTSDIR}/x11-toolkits/tk80
> > -CONFIGURE_TCL=	--with-tcl --with-tclconfig="${LOCALBASE}/lib/tcl8.0 ${LOCALBASE}/lib/tk8.0"
> > +LIB_DEPENDS=	tcl82.1:${PORTSDIR}/lang/tcl82 \
> > +		tk82.1:${PORTSDIR}/x11-toolkits/tk82
> > +CONFIGURE_TCL=	--with-tcl --with-tclconfig="${LOCALBASE}/lib/tcl8.2 ${LOCALBASE}/lib/tk8.2"
> >  .endif
> >  
> >  # if you want jdbc, type make WITH_JDBC=yes
> > @@ -103,14 +103,13 @@
> >  	@ ${SED} -e 's=!!PREFIX!!=${PREFIX}=g' \
> >  		${WRKSRC}/Makefile.global.in.old \
> >  		>> ${WRKSRC}/Makefile.global.in
> > -# pgaccess (accidentally?) removed from distribution, so leave it for now
> > -#.if defined(WITH_TCL)
> > -#	@ ${MV} ${WRKSRC}/bin/pgaccess/pgaccess.tcl \
> > -#		${WRKSRC}/bin/pgaccess/pgaccess.tcl.orig
> > -#	@ ${SED} -e "s=/usr/bin/wish=`/usr/bin/which wish8.0`=" \
> > -#		${WRKSRC}/bin/pgaccess/pgaccess.tcl.orig \
> > -#		>> ${WRKSRC}/bin/pgaccess/pgaccess.tcl
> > -#.endif
> > +.if defined(WITH_TCL)
> > +	@ ${MV} ${WRKSRC}/bin/pgaccess/pgaccess.sh \
> > +		${WRKSRC}/bin/pgaccess/pgaccess.sh.orig
> > +	@ ${SED} -e "s=__wish__=`/usr/bin/which wish8.2`=" \
> > +		${WRKSRC}/bin/pgaccess/pgaccess.sh.orig \
> > +		>> ${WRKSRC}/bin/pgaccess/pgaccess.sh
> > +.endif
> >  
> >  post-build:
> >  .if defined(WITH_JDBC)
> > 
> > 
> > >Release-Note:
> > >Audit-Trail:
> > >Unformatted:
> > 
> > 
> > To Unsubscribe: send mail to majordomo@FreeBSD.org
> > with "unsubscribe freebsd-ports" in the body of the message
> > 
> 
> Marc G. Fournier                   ICQ#7615664               IRC Nick: Scrappy
> Systems Administrator @ hub.org 
> primary: scrappy@hub.org           secondary: scrappy@{freebsd|postgresql}.org 
> 

	Adrian
--
[ adrian@ubergeeks.com -- Ubergeeks Consulting -- http://www.ubergeeks.com/ ]
Comment 3 Steve Price freebsd_committer freebsd_triage 2000-07-10 02:27:24 UTC
Responsible Changed
From-To: freebsd-ports->andreas

Over to port's maintainer.
Comment 4 andreas freebsd_committer freebsd_triage 2000-08-24 21:57:49 UTC
State Changed
From-To: open->closed

Will remove old postgreql port soon, since use of version 7.0.2 
is recommended.