Bug 193190

Summary: [maintainer] multimedia/plexhometheater build fails on FreeBSD 8
Product: Ports & Packages Reporter: Ben Woods <woodsb02>
Component: Individual Port(s)Assignee: Adam Weinberger <adamw>
Status: Closed FIXED    
Severity: Affects Only Me CC: adamw
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
PR193190 patch allowing build on FreeBSD 8
none
Fix PR193190 - Add binutils as builddep on FreeBSD8 and use cmake compiler in ffmpeg configure none

Description Ben Woods freebsd_committer freebsd_triage 2014-08-31 04:42:19 UTC
pkg-fallout is reporting that plexhometheater is failing to build on FreeBSD 8.4.

Log URL:        http://beefy1.isc.freebsd.org/data/84i386-default/2014-08-30_00h01m44s/logs/plexhometheater-1.2.1_1.log
Build URL:      http://beefy1.isc.freebsd.org/build.html?mastername=84i386-default&build=2014-08-30_00h01m44s
Comment 1 John Marino freebsd_committer freebsd_triage 2014-08-31 06:17:25 UTC
I don't understand the point of this PR.

FreeBSD notifies you, the maintainer, that multimedia/plexhometheater fails to build on FreeBSD 8.4, and then you open a PR to notify FreeBSD that multimedia/plexhometheater fails to build on 8.4

To point of pkg-fallout is to alert you there's a problem, so that you can provide a fix via PR.

Where's the fix for FreeBSD 8.4?
Comment 2 Ben Woods freebsd_committer freebsd_triage 2014-08-31 09:52:38 UTC
Hi John,
I am listed as the maintainer as I did the original porting work, however I do not have a commit bit and adamw committed the original port for me.
Since I do not have a commit bit, I raised this PR as I have been notified of a problem, and it seemed the right place for me to attach the patch once I have it ready.
Regards,
Ben
Comment 3 John Marino freebsd_committer freebsd_triage 2014-08-31 10:10:08 UTC
OPENING - MAINTAINER and SUBMITTER are the SAME
Comment 4 Ben Woods freebsd_committer freebsd_triage 2014-09-02 13:55:23 UTC
Created attachment 146682 [details]
PR193190 patch allowing build on FreeBSD 8
Comment 5 John Marino freebsd_committer freebsd_triage 2014-09-02 14:30:21 UTC
patch provided by maintainer, moving to patch-ready pool
Comment 6 Ben Woods freebsd_committer freebsd_triage 2014-09-03 22:47:16 UTC
Whilst that patch is necessary, it is not the whole story as the build still fails of FreeBSD 8 AMD64 (works on i386). Refer redports build below.
https://redports.org/buildarchive/20140902225401-11003/

{standard input}: Assembler messages:
{standard input}:184: Error: `(%r8d,%eax)' is not a valid 64 bit base/index expression
{standard input}:3811: Error: `(%esi,%eax)' is not a valid 64 bit base/index expression
gmake[1]: *** [libavcodec/vp5.o] Error 1
gmake[1]: *** [libavcodec/vp56.o] Error 1
gmake[1]: Leaving directory `/work/a/ports/multimedia/plexhometheater/work/.build/lib/ffmpeg/ffmpeg/src/ffmpeg-build'
*** Error code 2
1 error
*** Error code 2
1 error
*** Error code 2
1 error

According to the mailing list item below, this is caused by the need for newer GCC version. Whilst gcc-4.7.4.txz was installed as a part of the build depends, the compiler being used was --cc=/usr/bin/gcc --cxx=/usr/bin/g++.

Not quite ready to mark as solved yet...
Comment 7 Ben Woods freebsd_committer freebsd_triage 2014-09-09 13:45:08 UTC
John: can you please move this bug backwards from "patch ready" to "open" until I work out the remaining issues?
Comment 8 John Marino freebsd_committer freebsd_triage 2014-09-09 13:47:03 UTC
moving back to "open" state per maintainer request.
Comment 9 Ben Woods freebsd_committer freebsd_triage 2014-09-10 13:13:22 UTC
Created attachment 147169 [details]
Fix PR193190 - Add binutils as builddep on FreeBSD8 and use cmake compiler in ffmpeg configure

Try again: this patch now allows build on FreeBSD 8 (now it adds binutils as builddep).
Please mark this bug as patch ready.
Comment 10 John Marino freebsd_committer freebsd_triage 2014-09-10 13:22:08 UTC
ok
Comment 11 Adam Weinberger freebsd_committer freebsd_triage 2014-09-13 17:03:12 UTC
Committed