Bug 193209
| Summary: | [patch] install @sample files with mode u+w | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Olli Hauer <ohauer> | ||||
| Component: | Ports Framework | Assignee: | Port Management Team <portmgr> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Many People | CC: | bdrewery | ||||
| Priority: | --- | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Hmm, don't you have the authority to assign your PRs directly instead of letting it fall to people doing triage? assinging to portmgr@... This will fix it all at once https://reviews.freebsd.org/D703 (In reply to John Marino from comment #1) > Hmm, don't you have the authority to assign your PRs directly instead of > letting it fall to people doing triage? > > assinging to portmgr@... Sorry, I haven't noticed and assumed if I open a PR in infrastructure which has a remark portmgr@ it will be assigned automatically. (In reply to Olli Hauer from comment #3) > it will be assigned automatically. There's no automatic assignment in bugzilla. Although they are aliased, canonicalize assignment for searching purposes. Even the fix from https://reviews.freebsd.org/D703 was committed there are still ports affected (e.g. openldap24-server) because they use own install routines. Hacking all ports with own install routines is still more work then this fix. Index: Keywords/sample.ucl =================================================================== --- Keywords/sample.ucl (revision 369664) +++ Keywords/sample.ucl (working copy) @@ -22,7 +22,7 @@ esac target_file="${sample_file%.sample}" if ! [ -f "${target_file}" ]; then - /bin/cp -p "${sample_file}" "${target_file}" + /bin/cp -p "${sample_file}" "${target_file}" && /bin/chmod u+w "${target_file}" fi EOD pre-deinstall: <<EOD (In reply to Olli Hauer from comment #6) > Even the fix from https://reviews.freebsd.org/D703 was committed there are > still ports affected (e.g. openldap24-server) because they use own install > routines. > > Hacking all ports with own install routines is still more work then this fix. > > Index: Keywords/sample.ucl > =================================================================== > --- Keywords/sample.ucl (revision 369664) > +++ Keywords/sample.ucl (working copy) > @@ -22,7 +22,7 @@ > esac > target_file="${sample_file%.sample}" > if ! [ -f "${target_file}" ]; then > - /bin/cp -p "${sample_file}" "${target_file}" > + /bin/cp -p "${sample_file}" "${target_file}" && /bin/chmod u+w > "${target_file}" > fi > EOD > pre-deinstall: <<EOD I agree with this. A commit references this bug: Author: bdrewery Date: Fri Oct 3 18:33:32 UTC 2014 New revision: 369927 URL: https://svnweb.freebsd.org/changeset/ports/369927 Log: @sample: chmod u+w to ensure user may write to it. PR: 193209 Submitted by: ohauer With hat: portmgr Changes: head/Keywords/sample.ucl |
Created attachment 146611 [details] [patch] install @sample files with mode u+w Most of the @sample files are installed with u+r and this is not handy for fresh installs. I'm building my ports already with the patch, so my users don't have to change u+w the .conf files. The .sample file is not touched and keeps the original mode.