|Summary:||security/broccoli: PYTHON_USE -> USES= python|
|Product:||Ports & Packages||Reporter:||Craig Leres <leres>|
|Component:||Individual Port(s)||Assignee:||Kubilay Kocak <koobs>|
|Status:||Closed Overcome By Events|
|Severity:||Affects Only Me||CC:||koobs, leres|
|Priority:||---||Keywords:||easy, needs-patch, needs-qa|
Description Craig Leres 2014-09-01 18:53:05 UTC
Created attachment 146635 [details] patch to security/broccoli Update Makefile to use USES= python and fix some BRO_PREFIX issues.
Comment 1 Craig Leres 2014-09-01 18:53:44 UTC
Comment on attachment 146635 [details] patch to security/broccoli Here's a redports log for this change: https://redports.org/~leres/20140901180804-43828-239917/broccoli-2.3_1.log
Comment 2 Kubilay Kocak 2014-09-02 00:22:33 UTC
A poudriere testport with the PYTHON option turned on would be more useful for these changes. You can use the testport -c flag to run make config to achieve that. Please update the attached build log with the new output
Comment 3 Craig Leres 2014-09-02 02:02:31 UTC
I don't have a working poudriere environment, is there a way to test with a redports build? Or can I just capture the output of a build on my own build server?
Comment 4 Kubilay Kocak 2014-09-02 02:17:58 UTC
While poudriere is preferable (given its propensity to be more thorough with plist checks, you can add PYTHON to OPTIONS_DEFAULT and commit so redports will use the option when building. Just ensure you remove it if you need to update your patch again :)
Comment 5 Kubilay Kocak 2015-01-18 07:43:56 UTC
Are you sure you want to make python dependency unconditional, rather than just when the PYTHON option is on? The change from PYTHON_USE=python=yes (USE_PYTHON=yes) to PYTHON_USES=python (USES=python) was already made in: https://svnweb.freebsd.org/ports/head/security/broccoli/Makefile?r1=376179&r2=376178&pathrev=376179 Please advise
Comment 6 Craig Leres 2015-01-21 07:11:38 UTC
FYI, I think you're right and I'm working on an updated patch.
Comment 7 Craig Leres 2015-01-27 18:52:44 UTC
This patch was folded into this security update: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197107