Bug 193231
| Summary: | security/broccoli: PYTHON_USE -> USES= python | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Craig Leres <leres> | ||||
| Component: | Individual Port(s) | Assignee: | Kubilay Kocak <koobs> | ||||
| Status: | Closed Overcome By Events | ||||||
| Severity: | Affects Only Me | CC: | koobs, leres | ||||
| Priority: | --- | Keywords: | easy, needs-patch, needs-qa | ||||
| Version: | Latest | Flags: | koobs:
maintainer-feedback+
|
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Comment on attachment 146635 [details] patch to security/broccoli Here's a redports log for this change: https://redports.org/~leres/20140901180804-43828-239917/broccoli-2.3_1.log A poudriere testport with the PYTHON option turned on would be more useful for these changes. You can use the testport -c flag to run make config to achieve that. Please update the attached build log with the new output I don't have a working poudriere environment, is there a way to test with a redports build? Or can I just capture the output of a build on my own build server? While poudriere is preferable (given its propensity to be more thorough with plist checks, you can add PYTHON to OPTIONS_DEFAULT and commit so redports will use the option when building. Just ensure you remove it if you need to update your patch again :) Are you sure you want to make python dependency unconditional, rather than just when the PYTHON option is on? The change from PYTHON_USE=python=yes (USE_PYTHON=yes) to PYTHON_USES=python (USES=python) was already made in: https://svnweb.freebsd.org/ports/head/security/broccoli/Makefile?r1=376179&r2=376178&pathrev=376179 Please advise FYI, I think you're right and I'm working on an updated patch. This patch was folded into this security update:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197107
|
Created attachment 146635 [details] patch to security/broccoli Update Makefile to use USES= python and fix some BRO_PREFIX issues.