Bug 193272
| Summary: | [NEW PORT] games/xboard-devel: Slave of games/xboard with H.G.Muller’s version | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Kalten <kalten> | ||||||||||||||
| Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||||||||||||
| Status: | Closed FIXED | ||||||||||||||||
| Severity: | Affects Only Me | CC: | johans | ||||||||||||||
| Priority: | --- | Keywords: | needs-qa, patch | ||||||||||||||
| Version: | Latest | ||||||||||||||||
| Hardware: | Any | ||||||||||||||||
| OS: | Any | ||||||||||||||||
| See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193271 | ||||||||||||||||
| Bug Depends on: | 193271 | ||||||||||||||||
| Bug Blocks: | |||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Kalten
2014-09-03 02:53:59 UTC
Created attachment 146704 [details]
games/xboard-devel: ShellArchive
Created attachment 146707 [details]
log: poudriere testport output
Created attachment 146708 [details]
log: make.* output
setenv DEVELOPER yes; make clean; make stage && make check-plist && make stage-qa && make package
Initial review items: * Empty PORTREVISION=, remove * Empty PORTEPOCH=, remove * Missing COMMENT ? Additionally: Please run this through portlint -AC, and attach its output after addressing any oustanding issues. Pending patch update and portlint output to progress Created attachment 147191 [details] games/xboard-devel: ShellArchive {v2} As requested by Kubilay Kocak in Comment 4, I did use »portlint -AC« too. Now there are new files: A new patch superseding the old one. There will follow new logs (after this comment). * it is a real slave port now (see Bug 193271 Comment 6 with new version too) * I fear, I had not made this clear enough: This bug is blocked by Bug 193271 but I had not noticed the mechanism on top of a bug page with “Blocks:” and “Depends on:”—sorry for that! I have used it now. And now the output of »portlint -AC« with comments: ------------------------------------------------------------------------ > WARN: Makefile: ZIPPY is listed in OPTIONS_DEFINE, but no PORT_OPTIONS:MZIPPY appears. > WARN: Makefile: SOX is listed in OPTIONS_DEFINE, but no PORT_OPTIONS:MSOX appears. > WARN: Makefile: ALSA is listed in OPTIONS_DEFINE, but no PORT_OPTIONS:MALSA appears. > WARN: Makefile: XAW is listed in OPTIONS_DEFINE, but no PORT_OPTIONS:MXAW appears. > WARN: Makefile: XAW3D is listed in OPTIONS_DEFINE, but no PORT_OPTIONS:MXAW3D appears. > WARN: Makefile: GTK2 is listed in OPTIONS_DEFINE, but no PORT_OPTIONS:MGTK2 appears. > WARN: Makefile: FAIRYMAX is listed in OPTIONS_DEFINE, but no PORT_OPTIONS:MFAIRYMAX appears. > WARN: Makefile: CRAFTY is listed in OPTIONS_DEFINE, but no PORT_OPTIONS:MCRAFTY appears. > WARN: Makefile: GNUCHESS is listed in OPTIONS_DEFINE, but no PORT_OPTIONS:MGNUCHESS appears. > WARN: Makefile: KNIGHTCAP is listed in OPTIONS_DEFINE, but no PORT_OPTIONS:MKNIGHTCAP appears. > WARN: Makefile: PHALANX is listed in OPTIONS_DEFINE, but no PORT_OPTIONS:MPHALANX appears. They are included from games/xboard/Makefile and portlint(1) portlint does not check there. > WARN: Makefile: Consider adding support for a NLS knob to conditionally disable gettext support. It is done in the included games/xboard/Makefile and portlint(1) portlint does not check there. > WARN: Makefile: possible direct use of "files" "PATCHDIR= ${.CURDIR}/files" found. if so, use ${FILESDIR} instead. We have to set the directory for the patches for the games/xboard-devel as we must not use the directory of the master port, I think it is correct like this. Changing FILESDIR instead of PATCHDIR does not work. > WARN: Makefile: new ports should not set PORTREVISION. > WARN: Makefile: new ports should not set PORTEPOCH. As slave it has to overwrite all these. > WARN: Makefile: using hyphen in PORTNAME. consider using PKGNAMEPREFIX and/or PKGNAMESUFFIX. No, we are a devel port, I think, it is OK. > 0 fatal errors and 16 warnings found. ------------------------------------------------------------------------ I hope it is quite OK now. Thank you, Kalten Created attachment 147192 [details]
log: make.* output {v2}
setenv DEVELOPER yes; make clean; make stage && make check-plist && make stage-qa && make package
Created attachment 147193 [details]
log: poudriere testport output {v2}
A commit references this bug: Author: johans Date: Thu Sep 11 20:01:27 UTC 2014 New revision: 367971 URL: http://svnweb.freebsd.org/changeset/ports/367971 Log: New port: games/xboard-devel Created as a slave port of games/xboard X frontend for playing chess games, supporting several engines It is keeping up to date (as I hope) with the version of H.G.Muller at http://hgm.nubati.net/cgi-bin/gitweb.cgi/xboard.git as he seems to be the main maintainer correcting problems and adding features often whereas releases of xboard seem to be quite seldom. PR: 193272 Submitted by: kalten@gmx.at Changes: head/games/Makefile head/games/xboard-devel/ head/games/xboard-devel/Makefile head/games/xboard-devel/distinfo head/games/xboard-devel/files/ head/games/xboard-devel/files/OPTION_ZIPPY__patch-xboard.texi head/games/xboard-devel/files/patch-Makefile.am head/games/xboard-devel/files/patch-xboard.conf.in head/games/xboard-devel/pkg-plist Committed now, following the update to games/xboard that was awaiting my approval. Thanks for the hard work Kalten. |
