Summary: | [maintainer] update ports-mgmt/pkg_replace (more compatible "portupgrade") | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Ken DEGUCHI <kdeguchi> | ||||||||||
Component: | Individual Port(s) | Assignee: | Alex Kozlov <ak> | ||||||||||
Status: | Closed FIXED | ||||||||||||
Severity: | Affects Only Me | CC: | ak, marino | ||||||||||
Priority: | --- | ||||||||||||
Version: | Latest | ||||||||||||
Hardware: | Any | ||||||||||||
OS: | Any | ||||||||||||
Attachments: |
|
Created attachment 146763 [details]
including "pkg-message.in".
Sorry, previous patch does not include "pkg-message.in".
The USES line is missing a tab and the pkg-plist is now 4 entries long. I recommend that you remove the pkg-plist completely and use PLIST_FILES, etc. Can you make those changes and put pkg-message in a single patch (and obsolete these two patches)? Created attachment 146840 [details]
pkg_replace update 0.8.0 -> 20140721
OK, I made a patch as follows.
-Using PLIST_FILES instead of pkg-plist
-Add a tab to USES line
This is really close, but it needs one more iteration. minor: You need to actually remove all the lines after "WWW: ..." on pkg-descr. The package descriptions no longer reflect authors, maintainers, etc. This is true across the tree and if seen those are removed when the port is update. issue: You used PLIST_FILES which is good, but you didn't use PLIST_DIRS or PLIST_DIRSTRY. see https://www.freebsd.org/doc/en/books/porters-handbook/plist.html Can you fix that? preference: Can you change this: +.for i in ${PORTDOCS} + ${INSTALL_DATA} ${WRKSRC}/${i} \ + ${STAGEDIR}${DOCSDIR}/ +.endfor to + (cd ${WRKSRC} && ${INSTALL_DATA} ${PORTDOCS} ${STAGEDIR}${DOCSDIR}) What you had worked but I don't like unnecessary loops. And test that your change works. Everything else looks fine. Created attachment 146843 [details]
pkg_replace update 0.8.0 -> 20140721 (cleanup Makefile)
Fix issues:
-Cleanup pkg-descr.
-Using PLIST_DIRSTRY.
-Fix unnecessary loop.
Thanks, looks good. I'm moving this to patch-ready pool A commit references this bug: Author: ak Date: Sat Sep 6 18:51:47 UTC 2014 New revision: 367466 URL: http://svnweb.freebsd.org/changeset/ports/367466 Log: - Update to 20140721 * Increase pkg_replace compatibility with portupgrade - Update MASTER_SITES - Remove support for pkg_tools - Use PLIST_FILES PR: 193304 Submitted by: Ken DEGUCHI <kdeguchi@sz.tokoha-u.ac.jp> (maintainer) Changes: head/ports-mgmt/pkg_replace/Makefile head/ports-mgmt/pkg_replace/distinfo head/ports-mgmt/pkg_replace/files/ head/ports-mgmt/pkg_replace/files/pkg-message.in head/ports-mgmt/pkg_replace/pkg-descr head/ports-mgmt/pkg_replace/pkg-plist |
Created attachment 146762 [details] pkg_replace update 0.8.0 -> 20140721 Update pkg_replace 0.8.0 -> 20140721. pkg_replace-20140721 is more compatible "portupgrade" than previous version.