Bug 193313
| Summary: | [NEW PORT] www/py-wsgidav: wsgi implemented DAV | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Jingfeng Yan <yan_jingfeng> | ||||||||||||
| Component: | Individual Port(s) | Assignee: | John Marino <marino> | ||||||||||||
| Status: | Closed FIXED | ||||||||||||||
| Severity: | Affects Some People | CC: | marino, yan_jingfeng | ||||||||||||
| Priority: | --- | ||||||||||||||
| Version: | Latest | ||||||||||||||
| Hardware: | Any | ||||||||||||||
| OS: | Any | ||||||||||||||
| URL: | https://github.com/mar10/wsgidav | ||||||||||||||
| Bug Depends on: | |||||||||||||||
| Bug Blocks: | 193135, 193314 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Jingfeng Yan
2014-09-04 15:48:13 UTC
Created attachment 146796 [details]
new port shar file
Created attachment 146797 [details]
test port log
Thanks for your submission Jingfeng. A quick note that the following entries have been deprecated [1] * USE_PYTHON= 2 * USE_PYDISTUTILS= yes * PYDISTUTILS_AUTOPLIST= yes [1] See /Mk/Uses/python.mk for more information [2] Add DEVELOPER=yes to your make.conf to enable additional QA checks Additional review items: * LICENSE_FILE is missing * You can use CHEESESHOP for MASTER_SITES which sets MASTER_SITE_SUBDIR * Is there a reason the tests directory cant remain? * Attach portlint -AC output :) Feel free to update your attachment with those changes, and you may also use svn diff to assist review by our committers (In reply to Kubilay Kocak from comment #3) > Thanks for your submission Jingfeng. Thank you for your reviewing. > > A quick note that the following entries have been deprecated [1] > > * USE_PYTHON= 2 > * USE_PYDISTUTILS= yes > * PYDISTUTILS_AUTOPLIST= yes > > [1] See /Mk/Uses/python.mk for more information > [2] Add DEVELOPER=yes to your make.conf to enable additional QA checks > Fully accepted. Will update the port shar file in one or two minutes. > Additional review items: > > * LICENSE_FILE is missing LICENSE_FILE seems not to be mandatory and some py modules do not have full text of license. For example, zope213... The only LICENSE info only be carried in PKG-INFO file. > * You can use CHEESESHOP for MASTER_SITES which sets MASTER_SITE_SUBDIR Good learning, it makes life easier. I did struggle with upper/lowercase of MASTER_SITE_SUBDIR when I ported. > * Is there a reason the tests directory cant remain? Some of python modules have test directory. When install, it first detects __init__.py exists in the tests directory (some other modules have installed tests). The other thing that I don't understand well, all the python modules' tests directory install to the same location, and is there any way to avoid name conflict? __init__.py is place holder in most of cases (but it could do something, too). How about other file names. If there is better way to keep the tests directory, I will follow. > * Attach portlint -AC output :) will do. > > Feel free to update your attachment with those changes, and you may also use > svn diff to assist review by our committers no svn diff, but diff this time. Will do in the future. Created attachment 146869 [details]
diff to shar file 146796: new port shar file
Created attachment 146870 [details]
new shar file replace to 146796
Created attachment 146871 [details]
portlint -AC output
(In reply to Jingfeng Yan from comment #4) > (In reply to Kubilay Kocak from comment #3) > > Thanks for your submission Jingfeng. > Thank you for your reviewing. You're welcome > > Additional review items: > > > > * LICENSE_FILE is missing > LICENSE_FILE seems not to be mandatory and some py modules do not have full > text of license. For example, zope213... The only LICENSE info only be > carried in PKG-INFO file. Include it if the distribution files contain a standalone license file. If not that's fine > > * Is there a reason the tests directory cant remain? > Some of python modules have test directory. When install, it first detects > __init__.py exists in the tests directory (some other modules have installed > tests). The other thing that I don't understand well, all the python > modules' tests directory install to the same location, and is there any way > to avoid name conflict? > __init__.py is place holder in most of cases (but it could do something, > too). How about other file names. If there is better way to keep the tests > directory, I will follow. Certainly clean up if the python package installs conflicting files. It's prudent to create issue reports for these things upstream, so that authors can learn to improve their packaging methods, and we can also leverage test functionality. One last thing, When you're providing updates to previous submitted attachments, remove all attachments except for the latest (and complete) versions you want to be reviewed and committed. The diff of the last requested changes is not needed, only the latest version. <sigh> Koobs moved this to Siberia but didn't stay on CC list. Of course it got lost because nobody cyclically reviews open PRs. Moving this to patch-ready. The tabbing on the Makefile is wrong but it's only a few lines and can be fixed by submitter quickly. I didn't notice this belonged to python -- so it wasn't in Siberia after all. I thought it was still unassigned. I'm taking it now though, it's been two months! A commit references this bug: Author: marino Date: Thu Nov 6 19:53:39 UTC 2014 New revision: 372235 URL: https://svnweb.freebsd.org/changeset/ports/372235 Log: Add new port www/py-wsgidav PR: 193313 Submitted by: JingFeng Yan WsgiDAV is a WebDAV server for sharing files and other resources over the web. It is based on the WSGI interface. It comes bundled with a simple WSGI web server. This package is based on PyFileServer by Ho Chun Wei. Changes: head/www/Makefile head/www/py-wsgidav/ head/www/py-wsgidav/Makefile head/www/py-wsgidav/distinfo head/www/py-wsgidav/pkg-descr I think your editor was set to 4-space tabs or something. The makefile was completely mis-tabbed. That was the only issue I saw. Thanks for your patience. (In reply to John Marino from comment #12) > I think your editor was set to 4-space tabs or something. The makefile was > completely mis-tabbed. That was the only issue I saw. Thanks for your > patience. Thank you for your explanation and efforts! I fully understand that most of people are voluntarily serve the FreeBSD community, I appreciate all the hard works from you and other people. This is a big year for FreeBSD port system, we wish it could be better and stronger. For the tab, it seems that the Sept correction of vimrc has problem. The more recent one could be normal (TAB is 8). But, I believe there is still issue, because the display from vim is still urgly, which leads to somewhere is 2 TABs, other places are 3 TABs. |
