Bug 193405

Summary: [MAINTAINER] news/nzbget: Update to 13.0
Product: Ports & Packages Reporter: Toxic <toxic>
Component: Individual Port(s)Assignee: Jason E. Hale <jhale>
Status: Closed FIXED    
Severity: Affects Only Me CC: jhale, toxic
Priority: --- Keywords: easy, needs-qa, patch
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch generated by svn.
toxic: maintainer-approval+
Updated patch.
none
Portlint -AC output.
none
poudriere build log.
none
Improvements for nzbget jhale: maintainer-approval? (toxic)

Description Toxic 2014-09-07 01:19:27 UTC
Created attachment 146974 [details]
Patch generated by svn.

Updates news/nzbget from 12.0_3 to 13.0_1.

ppscripts directory has been renamed to scripts.
version is bumped.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2014-09-07 13:07:42 UTC
If possible please also include the following to promote quick 
resolution:

 * Attach successful poudriere testport, or redports.org build logs
 * portlint -AC output (after addressing any outstanding issues)
Comment 2 Toxic 2014-09-07 19:39:59 UTC
Created attachment 147027 [details]
Updated patch.
Comment 3 Toxic 2014-09-07 19:40:18 UTC
Created attachment 147028 [details]
Portlint -AC output.
Comment 4 Toxic 2014-09-07 19:41:08 UTC
Created attachment 147029 [details]
poudriere build log.
Comment 5 Jason E. Hale freebsd_committer freebsd_triage 2014-09-07 22:50:47 UTC
Created attachment 147034 [details]
Improvements for nzbget

There are a few things that need fixed.

Makefile:
- PORTREVISION should return to 0 when PORTVERSION is increased
- This port links to ncurses, to USES=ncurses should be used along with the appropriate CONFIGURE_ARGS so the port is aware of whether to use the library from the base or ports
- The python scripts should have their shebang lines fixed (USES=shebangfix)
- Python appears to only be a runtime dependency, so limit it to that (BTW, when using options helpers, don't use '+=').  Do you know whether those scripts work with python 3.x?  If not, the port should be limited to use 2.x only.
- The post-configure hack can be dropped in favor of redefining BINMODE. 755 is more appropriate than 655 because the binaries/scripts should be executable by the owner too.  SHAREMODE was recently changed to 0644, as well, so the second substitution no longer applies.

pkg-plist:
- @sample should be used
- No point installing an additional copy of the license; @comment it out
- Sort
Comment 6 Toxic 2014-09-08 02:14:42 UTC
The improvements in the patch attached as #147034 look fine by me.  

Thanks a lot for cleaning this up.
Comment 7 commit-hook freebsd_committer freebsd_triage 2014-09-08 21:24:51 UTC
A commit references this bug:

Author: jhale
Date: Mon Sep  8 21:24:08 UTC 2014
New revision: 367704
URL: http://svnweb.freebsd.org/changeset/ports/367704

Log:
  - Update to 13.0
  - Fix shebangs
  - Allow linking to ncurses library from port or base
  - Remove post-configure patch and redefine BINMODE instead
  - Convert USE_PYTHON -> USES=python:run
  - Use @sample in pkg-plist
  - Don't install multiple copies of LICENSE

  PR:		193405 (based on)
  Submitted by:	Toxic <toxic@doobie.com> (maintainer)

Changes:
  head/news/nzbget/Makefile
  head/news/nzbget/distinfo
  head/news/nzbget/pkg-plist