Bug 193420

Summary: [NEW PORT] net/ng_mikrotik_eoip: Kernel module for Mikrotik Ethernet-over-IP Tunneling Protocol
Product: Ports & Packages Reporter: gelraen.ua
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed FIXED    
Severity: Affects Only Me CC: pi
Priority: Normal Keywords: patch
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
.shar with updated port
none
Update .shar
none
Output of `poudriere testport` none

Description gelraen.ua 2014-09-07 10:32:37 UTC
Created attachment 146991 [details]
.shar with updated port

Adding it back per request user request. Updated to support staging.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2014-09-07 13:36:29 UTC
Thanks for your submission Maxim.

Initial review items:

 * Use OPTIONS helpers: MPTABLE_MAKE_ARGS
 * Add LICENSE_FILE is a standalone license exists in the distribution files
 * Strip trailing slash from pkg-descr WWW: URL
 
If possible please also include the following to promote quick 
resolution:

 * Attach successful poudriere testport, or redports.org build logs
 * portlint -AC output (after addressing any outstanding issues)
Comment 2 gelraen.ua 2014-09-07 19:10:54 UTC
Created attachment 147025 [details]
Update .shar

(In reply to Kubilay Kocak from comment #1)
> Thanks for your submission Maxim.
> 
> Initial review items:
> 
>  * Use OPTIONS helpers: MPTABLE_MAKE_ARGS
Done.

>  * Add LICENSE_FILE is a standalone license exists in the distribution files
Nope, there's just Makefile and *.{c,h}

>  * Strip trailing slash from pkg-descr WWW: URL
Wat. It points to a directory on a web server with index.html, not a file or something else.

>  
> If possible please also include the following to promote quick 
> resolution:
> 
>  * Attach successful poudriere testport, or redports.org build logs
Will do soon.
>  * portlint -AC output (after addressing any outstanding issues)

WARN: /mnt/ext_hdd/poudriere/ports/default/net/ng_mikrotik_eoip/pkg-plist: [2]: installing to directory / discouraged. could you please avoid it?
WARN: Makefile: possible use of absolute pathname "/boot/modules".
WARN: Makefile: possible direct use of "files" "IGNORE=         requires kernel source files" found. if so, use ${FILESDIR} instead.
0 fatal errors and 3 warnings found.
Comment 3 gelraen.ua 2014-09-07 19:12:10 UTC
Created attachment 147026 [details]
Output of `poudriere testport`
Comment 4 commit-hook freebsd_committer freebsd_triage 2014-10-21 05:26:25 UTC
A commit references this bug:

Author: pi
Date: Tue Oct 21 05:25:35 UTC 2014
New revision: 371308
URL: https://svnweb.freebsd.org/changeset/ports/371308

Log:
  New port: net/ng_mikrotik_eoip

  Netgraph node for Mikrotik Ethernet-over-IP tunneling support

  WWW: http://imax.in.ua/ng_mikrotik_eoip/

  PR:		193420
  Submitted by:	gelraen.ua@gmail.com

Changes:
  head/net/Makefile
  head/net/ng_mikrotik_eoip/
  head/net/ng_mikrotik_eoip/Makefile
  head/net/ng_mikrotik_eoip/distinfo
  head/net/ng_mikrotik_eoip/pkg-descr
  head/net/ng_mikrotik_eoip/pkg-plist
Comment 5 Kurt Jaeger freebsd_committer freebsd_triage 2014-10-21 05:27:55 UTC
Committed, thanks!