Bug 193461

Summary: sysutils/logstash-forwarder: Update to 0.3.1.20140829, Convert use bsd.go.mk
Product: Ports & Packages Reporter: cheffo
Component: Individual Port(s)Assignee: Thomas Zander <riggs>
Status: Closed FIXED    
Severity: Affects Only Me CC: cheffo, riggs
Priority: --- Keywords: needs-patch, needs-qa
Version: Latest   
Hardware: Any   
OS: Any   
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193012
Attachments:
Description Flags
patch the port to latest version.
none
Attached shar archive if preferred over patch.
none
poudriere testport output none

Description cheffo 2014-09-08 11:27:01 UTC 
Created attachment 147059 [details]
patch the port to latest version.

This patch:

- Updates logstash-forwarder to latest version (0.3.1.20140829)
- fix startup script and send noisy startup messages to /dev/null
- converts the port to use bsd.go.mk file as suggested in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193012

portlint output: looks fine.
poudriere testport output: looks fine.
Comment 1 cheffo 2014-09-08 11:30:05 UTC 
Created attachment 147060 [details]
Attached shar archive if preferred over patch.
Comment 2 John Marino freebsd_committer freebsd_triage 2014-09-08 12:51:48 UTC 
FYI, a shar is only used for new ports.  It's never preferred over a patch on existing ports.
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2014-09-27 23:39:59 UTC 
If possible please also include the following QA results to promote quick 
resolution:

 * Attach successful poudriere testport, or redports.org build logs
 * Attach portlint -AC output (after addressing any outstanding issues)
Comment 4 cheffo 2014-09-29 08:28:14 UTC 
Hi,

QA results are already attached but here is the output anyway.
portlint -AC: looks fine.
poudriere testport output: looks fine.
Comment 5 John Marino freebsd_committer freebsd_triage 2014-10-05 20:56:38 UTC 
(In reply to cheffo from comment #4)
> poudriere testport output: looks fine.

"looks fine" is not something poudriere would say.  koobs was looking for an entire build log, either a link or an attachment.

"looks fine" is something portlint would say though.
Comment 6 cheffo 2014-10-06 09:05:02 UTC 
Created attachment 148024 [details]
poudriere testport output

Please see the attached txt file that contains all outputs from poudriere testport. Looks like I misunderstood you are interested only from logstash-forwarder-0.3.1.20140829.portlint.log file.
Comment 7 John Marino freebsd_committer freebsd_triage 2014-10-06 09:10:02 UTC 
Yes, we only wanted the log, which does indeed look good.

My only comment from looking at the output is that the pkg-message could be altered to use the real value of $PREFIX instead of printed out ${PREFIX} but I guess that's relatively minor.

Moving to patch-ready pool
Comment 8 commit-hook freebsd_committer freebsd_triage 2014-10-12 08:00:49 UTC 
A commit references this bug:

Author: riggs
Date: Sun Oct 12 08:00:31 UTC 2014
New revision: 370686
URL: https://svnweb.freebsd.org/changeset/ports/370686

Log:
  - Update to upstream version 0.3.1.20140829
  - Convert to using bsd.go.mk

  PR:		193461
  Submitted by:	cheffo@freebsd-bg.org (maintainer)

Changes:
  head/sysutils/logstash-forwarder/Makefile
  head/sysutils/logstash-forwarder/distinfo
  head/sysutils/logstash-forwarder/files/logstash-forwarder.in