Bug 193474
| Summary: | security/webshag: some ports improvements. | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | clutton | ||||||||||
| Component: | Individual Port(s) | Assignee: | Tobias Kortkamp <tobik> | ||||||||||
| Status: | Closed Overcome By Events | ||||||||||||
| Severity: | Affects Only Me | CC: | jhale, tobik | ||||||||||
| Priority: | --- | ||||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
clutton
2014-09-09 03:01:36 UTC
Created attachment 147092 [details]
build log
Patch looks fine for the issues that were brought up, but there are other issues that should have been addressed before this port was added: - webshag.conf should probably be installed as webshag.conf.sample and use the @sample keyword in pkg-plist so that edited configs don't get overwritten. - patch-setup_linux_py uses hard-coded paths for PREFIX and LOCALBASE...this should be fixed. You could use %%PREFIX%% and %%LOCALBASE%% in the patch instead, then use a post-patch replacement. - Python bytecode should be pre-generated with and without the -O flag (.pyo and .pyc files) for everything installed in PYTHON_SITELIBDIR so there are no leftovers. (In reply to Jason E. Hale from comment #2) > Patch looks fine for the issues that were brought up, but there are other > issues that should have been addressed before this port was added: > > - webshag.conf should probably be installed as webshag.conf.sample and use > the @sample keyword in pkg-plist so that edited configs don't get > overwritten. > - patch-setup_linux_py uses hard-coded paths for PREFIX and LOCALBASE...this > should be fixed. You could use %%PREFIX%% and %%LOCALBASE%% in the patch > instead, then use a post-patch replacement. > - Python bytecode should be pre-generated with and without the -O flag (.pyo > and .pyc files) for everything installed in PYTHON_SITELIBDIR so there are > no leftovers. USE_PYTHON= distutils PYSETUP= setup.linux.py I'm not sure how can I use -O flag. Because some things are already predefined in /usr/ports/Mk/Uses/python.mk PYDISTUTILS_CONFIGUREARGS?= # empty PYDISTUTILS_BUILDARGS?= # empty PYDISTUTILS_INSTALLARGS?= -c -O1 --prefix=${PREFIX} .if defined(_PYTHON_FEATURE_DISTUTILS) . if !defined(PYDISTUTILS_INSTALLNOSINGLE) Created attachment 147153 [details]
new patch with %%PREFIX%% and @sample
The sub for nmap should be LOCALBASE, not PREFIX As for the Python bytecode stuff, have a look at the post-install target of astro/gpsd for an example of how to handle it. Of course, pkg-plist will have to include those files as well. Created attachment 147408 [details]
PREFIX -> LOCALBASE
Python bytecode should be pre-generated with and without the -O flag (.pyo and .pyc files) for everything installed in PYTHON_SITELIBDIR so there are no leftovers. There's no bytecode. cd /tmp/usr/ports/security/webshag/work/stage/usr/local Ξ usr/local → find . -type f ./bin/webshag_cli ./lib/python2.7/site-packages/webshag/gui/__init__.py ./lib/python2.7/site-packages/webshag/gui/gui_pscan.py ./lib/python2.7/site-packages/webshag/gui/gui.py ./lib/python2.7/site-packages/webshag/gui/gui_spider.py ./lib/python2.7/site-packages/webshag/gui/gui_info.py ./lib/python2.7/site-packages/webshag/gui/gui_widgets.py ./lib/python2.7/site-packages/webshag/gui/gui_images.py ./lib/python2.7/site-packages/webshag/gui/gui_uscan.py ./lib/python2.7/site-packages/webshag/gui/gui_fuzz.py ./lib/python2.7/site-packages/webshag/__init__.py ./lib/python2.7/site-packages/webshag/core/core_http.py ./lib/python2.7/site-packages/webshag/core/__init__.py ./lib/python2.7/site-packages/webshag/core/core_error.py ./lib/python2.7/site-packages/webshag/core/core_utilities.py ./lib/python2.7/site-packages/webshag/core/core_file.py ./lib/python2.7/site-packages/webshag/modules/module_pscan.py ./lib/python2.7/site-packages/webshag/modules/__init__.py ./lib/python2.7/site-packages/webshag/modules/module_uscan.py ./lib/python2.7/site-packages/webshag/modules/module_spider.py ./lib/python2.7/site-packages/webshag/modules/module_info.py ./lib/python2.7/site-packages/webshag/modules/module_fuzz.py ./lib/python2.7/site-packages/webshag/update/update.py ./lib/python2.7/site-packages/webshag/update/__init__.py ./lib/python2.7/site-packages/webshag/export/__init__.py ./lib/python2.7/site-packages/webshag/export/export.py ./share/licenses/webshag-1.10/GPLv3 ./share/licenses/webshag-1.10/LICENSE ./share/licenses/webshag-1.10/catalog.mk ./share/webshag/proxies/proxies.txt ./share/webshag/fuzzer/directory-list-2.3-small.txt ./share/webshag/fuzzer/extensions.txt ./share/webshag/fuzzer/directory-list-1.0.txt ./share/webshag/custom/custom_tests.db ./share/webshag/custom/banners.db ./share/webshag/nikto/db_tests ./share/webshag/nikto/db_variables ./etc/webshag.conf.sample The last update to this bug was > 3 years ago. Is this still relevant? (In reply to Tobias Kortkamp from comment #8) Nope. I'd love to have this scanner removed from ports tree, since better ones available and this was abandoned. (In reply to clutton from comment #9) No problem, I'll mark it DEPRECATED and drop you as maintainer. A commit references this bug: Author: tobik Date: Sun Oct 22 14:42:36 UTC 2017 New revision: 452648 URL: https://svnweb.freebsd.org/changeset/ports/452648 Log: security/webshag: Mark deprecated There are better audit tools available and this was abandoned. - Also reset maintainer PR: 193474 Requested by: clutton@zoho.com (maintainer) Changes: head/security/webshag/Makefile Done. Thanks! (In reply to Tobias Kortkamp from comment #12) Tnx, would it be deleted or I have to confirm something? (In reply to clutton from comment #13) I've set an expiration date for 2017-11-30, so hopefully it'll be deleted shortly after. You won't have to do anything. (In reply to Tobias Kortkamp from comment #14) Ok, thank you good sir! |
