Bug 193511

Summary: net/tcptraceroute-devel: Revive port, Take Maintainership
Product: Ports & Packages Reporter: Chris Hutchinson <portmaster>
Component: Individual Port(s)Assignee: Chris Hutchinson <portmaster>
Status: Closed FIXED    
Severity: Affects Some People CC: mandree, portmaster
Priority: --- Keywords: easy, patch
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
net/tcptracroute-devel REVIVE -- svn diff
none
net-tcptraceroute-devel QA for the diff that accompanies this pr(1) none

Description Chris Hutchinson 2014-09-10 07:23:55 UTC
Created attachment 147156 [details]
net/tcptracroute-devel REVIVE -- svn diff

net/tcptraceroute-devel

revive net/tcptraceroute-devel
request MAINTAINER
adds STAGEDIR, MASTER_SITES, LICENSE

Please find 2014-09-09.diff, for details.
See also net-tcptraceroute-QA, for requisite QA,
also attached.

Thanks!

--Chris

P.S. I'm not sure about the ${CHMOD}. But it was there, so I
left it, for greater powers to decide on. :)
Comment 1 Chris Hutchinson 2014-09-10 07:27:54 UTC
Created attachment 147157 [details]
net-tcptraceroute-devel QA for the diff that accompanies this pr(1)

net/tcptraceroute-devel

The requisite QA, to accompany the diff submitted with this pr(1)

Thanks!

--Chris
Comment 2 John Marino freebsd_committer freebsd_triage 2014-09-10 12:16:53 UTC
Rework title to avoid "[]" abuse.

In general, don't mention every little thing the PR does.  We don't care.  Mention the 1 or 2 big ticket items.  In this case, revival and maintainership request are the two big items, and the maintainership request really isn't very important either.  You could just mention "revive" and the port name and that would be sufficient.

On titles, more is not better.
(This has been bugging me for a while)
Comment 3 John Marino freebsd_committer freebsd_triage 2014-09-10 12:18:00 UTC
And don't mention STAGE in the title every again.  All ports must be staged now, it's assumed.  I only saw this PR because I'm searching for staging PRs.
Comment 4 Chris Hutchinson 2014-09-10 12:55:31 UTC
(In reply to John Marino from comment #3)
> And don't mention STAGE in the title every again.  All ports must be staged
> now, it's assumed.  I only saw this PR because I'm searching for staging PRs.

OK. Sure. Stage was such a big deal. I guess it just became a habit.

--Chris
Comment 5 Matthias Andree freebsd_committer freebsd_triage 2014-10-11 01:01:08 UTC
- The pre-install wasn't necessary, I dropped it.
- The CHMOD must affect the STAGEDIR, hence goes into post-install:
- I removed the @dirrm from pkg-plist, no longer needed because pkg will auto-remove directories it created to store files in.

Committed as r370621. Thanks!
Comment 6 commit-hook freebsd_committer freebsd_triage 2014-10-11 01:01:10 UTC
A commit references this bug:

Author: mandree
Date: Sat Oct 11 01:00:47 UTC 2014
New revision: 370621
URL: https://svnweb.freebsd.org/changeset/ports/370621

Log:
  Revive net/tcptraceroute-devel port, with a new maintainer.
  Update MASTER_SITES, add LICENSE.

  NOTE: this has some minor changes over the original submission, detailed
  in the PR.

  PR:		193511
  Submitted by:	C. Hutchinson <portmaster@bsdforge.com>

Changes:
  head/net/Makefile
  head/net/tcptraceroute-devel/
  head/net/tcptraceroute-devel/Makefile
  head/net/tcptraceroute-devel/pkg-descr
  head/net/tcptraceroute-devel/pkg-plist
Comment 7 Matthias Andree freebsd_committer freebsd_triage 2014-10-11 01:19:24 UTC
Note that the WWW: site from pkg-descr is currently down for me.
Please check:

$ curl -vI http://BSDforge.com/projects/net/tcptraceroute/
* Hostname was NOT found in DNS cache
*   Trying 209.180.214.225...
* connect to 209.180.214.225 port 80 failed: Connection refused
* Failed to connect to BSDforge.com port 80: Connection refused
* Closing connection 0
curl: (7) Failed to connect to BSDforge.com port 80: Connection refused
Comment 8 Chris Hutchinson 2014-10-14 21:56:09 UTC
(In reply to Matthias Andree from comment #7)
> Note that the WWW: site from pkg-descr is currently down for me.
> Please check:
> 
> $ curl -vI http://BSDforge.com/projects/net/tcptraceroute/
> * Hostname was NOT found in DNS cache
> *   Trying 209.180.214.225...
> * connect to 209.180.214.225 port 80 failed: Connection refused
> * Failed to connect to BSDforge.com port 80: Connection refused
> * Closing connection 0
> curl: (7) Failed to connect to BSDforge.com port 80: Connection refused

RESOLVED.
Unplanned RELENG_8 ==> RELENG_9 upgrade interrupted the service.

--Chris
Comment 9 Matthias Andree freebsd_committer freebsd_triage 2014-10-15 07:06:07 UTC
web site does not have contents
Comment 10 Chris Hutchinson 2014-10-15 08:51:14 UTC
(In reply to Matthias Andree from comment #9)
> web site does not have contents

You are mistaken. The source has always been available. With the exception
of ~9hrs. during an unplanned server upgrade.
Please find log of session below.

--Chris


Script started on Wed Oct 15 01:41:33 2014

# mkdir ./test

# svn co --depth empty svn://svn.freebsd.org/ports/head test

 U   test
Checked out revision 370895.

# svn up --set-depth empty test/net

Updating 'test/net':
A    test/net
Updated to revision 370895.

# svn up test/net/tcptraceroute-devel

Updating 'test/net/tcptraceroute-devel':
A    test/net/tcptraceroute-devel
A    test/net/tcptraceroute-devel/pkg-plist
A    test/net/tcptraceroute-devel/Makefile
A    test/net/tcptraceroute-devel/distinfo
A    test/net/tcptraceroute-devel/pkg-descr
A    test/net/tcptraceroute-devel/files
A    test/net/tcptraceroute-devel/files/patch-configure
Updated to revision 370895.

# cd test/net/


# cd tcptraceroute-devel/

# ls

Makefile  distinfo  pkg-descr pkg-plist

# make fetch

===>  License GPLv2 accepted by the user
===>   tcptraceroute-devel-1.5.b7_1 depends on file: /usr/local/sbin/pkg - found
=> tcptraceroute-1.5beta7.tar.gz doesn't seem to exist in /usr/ports/distfiles/.
=> Attempting to fetch http://BSDforge.com/projects/source/net/tcptraceroute/tcptraceroute-1.5beta7.tar.gz

tcptraceroute-1.5beta7.tar.gz                   0% of  116 kB    0  Bps
tcptraceroute-1.5beta7.tar.gz                 100% of  116 kB  266 MBps 00m00s
===> Fetching all distfiles required by tcptraceroute-devel-1.5.b7_1 for building

# exit

exit

Script done on Wed Oct 15 01:43:47 2014
Comment 11 Matthias Andree freebsd_committer freebsd_triage 2014-10-15 22:54:31 UTC
Chris, thank you.

However, I was (comment #7) and still am writing about the WWW: address from pkg-descr, not the distfile...

I only get

  "net/tcptraceroute-devel
  page is on it's way!"

Now that it's at least reachable I'll close this PR again,
but note someone else may file a new PR on the WWW: site.