Bug 193542
| Summary: | [MAINTAINER] x11-fonts/alef: Bump PORTREVISION | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Carlos J Puga Medina <cjpm> | ||||||
| Component: | Individual Port(s) | Assignee: | Jason E. Hale <jhale> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | jhale | ||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Build logs via redports: https://redports.org/buildarchive/20140910225252-52728/ - Comment should not start with indefinite article "A"
- Installation commands should not be muted (mkdirs OK)
- Installation of DOCS should not be conditional. Staging will take care of it automatically
- To install the DOCS without the for loop, the easiest way is:
${INSTALL_DATA} ${PORTDOCS:S|^|${WRKDIR}/|} ${STAGEDIR}${DOCSDIR}
- This port has a BUILD_DEPENDS on fc-cache(1), which it doesn't even use
- It should be running mkfontdir(1) and mkfontscale(1) in the directory where the fonts are. Of course, the generated files need added to pkg-plist.
- It would be better if NO_WRKSUBDIR were set, then you wouldn't have to redefine WRKSRC and it would eliminate the first two lines of the post-extract target.
- Since LICENSE_FILE is being added, it should be removed from PORTDOCS so that it isn't installed twice
Created attachment 147241 [details]
alef-1.0_1.diff
(In reply to Jason E. Hale from comment #2) > - Comment should not start with indefinite article "A" > - Installation commands should not be muted (mkdirs OK) > - Installation of DOCS should not be conditional. Staging will take care of > it automatically > - To install the DOCS without the for loop, the easiest way is: > ${INSTALL_DATA} ${PORTDOCS:S|^|${WRKDIR}/|} ${STAGEDIR}${DOCSDIR} > - This port has a BUILD_DEPENDS on fc-cache(1), which it doesn't even use > - It should be running mkfontdir(1) and mkfontscale(1) in the directory > where the fonts are. Of course, the generated files need added to pkg-plist. > - It would be better if NO_WRKSUBDIR were set, then you wouldn't have to > redefine WRKSRC and it would eliminate the first two lines of the > post-extract target. > - Since LICENSE_FILE is being added, it should be removed from PORTDOCS so > that it isn't installed twice Done! Thank you for the triage. % portlint -ac WARN: Consider to set DEVELOPER=yes in /etc/make.conf 0 fatal errors and 1 warning found. Build logs via redports (after last port revision): https://redports.org/buildarchive/20140912091400-49436/ A commit references this bug: Author: jhale Date: Fri Sep 12 21:15:15 UTC 2014 New revision: 368067 URL: http://svnweb.freebsd.org/changeset/ports/368067 Log: - Drop indefinite article from COMMENT - Add LICENSE_FILE and remove it from PORTDOCS - Use NO_WRKSUBDIR to avoid redefining WRKSRC - Create and install font indexes - Simplify PORTDOCS installation - Bump PORTREVISION PR: 193542 Submitted by: Carlos Jacobo Puga Medina <cpm@fbsd.es> (maintainer) Changes: head/x11-fonts/alef/Makefile head/x11-fonts/alef/pkg-plist Committed with minor changes. Thanks! |
Created attachment 147197 [details] alef-1.0_1.diff - Clean-up Makefile - Bump PORTREVISION