Bug 19367

Summary:	/etc/defaults/make.conf lists wrong value for PERL_THREADED
Product:	Base System	Reporter:	patl <patl>
Component:	misc	Assignee:	Mark Murray <markm>
Status:	Closed FIXED
Severity:	Affects Only Me
Priority:	Normal
Version:	4.0-STABLE
Hardware:	Any
OS:	Any

Description patl 2000-06-18 18:10:00 UTC

In /etc/defaults/make.conf there is a commented-out entry for
PERL_THREADED, with a comment indicating that uncommenting it
will build perl with multi-thread support.  It quietly fails.
The value should be 'yes', not 'true'.

Fix: 

Change the value of the PERL_THREADED macro to: yes
How-To-Repeat: copy the PERL_THREADED=true line to /etc/make.conf and 'make world';
then run 'perl -V'.  You will see that it lists usethreads=undef.

Comment 1 k 2000-08-03 17:33:21 UTC

Hi 

I think a better solution is to change
/usr/src/gnu/usr.bin/perl/perl/Makefile:.if ${PERL_THREADED} == "yes"
/usr/src/gnu/usr.bin/perl/Makefile.inc:PERL_THREADED?= no
/usr/src/gnu/usr.bin/perl/Makefile.inc:.if ${PERL_THREADED} == "yes"

to use 'true' instead since our make.conf uses true for every other value.


in /usr/src/gnu/usr.bin/perl/perl/
--- Makefile.~1~	Thu Aug  3 18:27:23 2000
+++ Makefile	Thu Aug  3 18:28:03 2000
@@ -24,7 +24,7 @@
 DYNAMIC_EXT=	B/B DB_File/DB_File Data/Dumper/Dumper Fcntl/Fcntl IO/IO \
 		IPC/SysV/SysV NDBM_File/NDBM_File Opcode/Opcode POSIX/POSIX \
 		SDBM_File/SDBM_File Socket/Socket attrs/attrs re/re
-.if ${PERL_THREADED} == "yes"
+.if ${PERL_THREADED} != "no"
 DYNAMIC_EXT+=	Thread/Thread
 .endif
 

in /usr/src/gnu/usr.bin/perl/
--- Makefile.inc.~1~	Thu Aug  3 18:27:27 2000
+++ Makefile.inc	Thu Aug  3 18:28:26 2000
@@ -58,7 +58,7 @@
 FARMDIRS=	lib ext Porting hints
 
 PERL_THREADED?= no
-.if ${PERL_THREADED} == "yes"
+.if ${PERL_THREADED} != "no"
 CFLAGS+=        -pthread
 THREAD=		threads-
 .endif


Mark (markm), can you please have a look at this since you made the changes.

Thanks
Johan K

Comment 2 Sheldon Hearn freebsd_committer

2000-08-03 17:46:53 UTC

Responsible Changed
From-To: freebsd-bugs->markm

Johan's feedback will be interesting to the perl5 maintainer.

Comment 3 patl 2001-03-18 07:36:20 UTC

As of 4.3-BETA (2001-03-17), it appears that the Makefiles themselves
are inconsistant.
/usr/src/gnu/usr.bin/perl/Makefile.inc tests PERL_THREADED against
"true" but
/usr/src/gnu/usr.bin/perl/library/Makefile tests it against "yes"
/etc/defaults/make.conf suggests "true"


-Pat

Comment 4 Anton Berezin freebsd_committer

2001-08-29 18:08:49 UTC

State Changed
From-To: open->closed

We have no PERL_THREADED any longer.