Bug 193766

Summary: [PATCH] misc/mc - incorrect ZIP variable value
Product: Ports & Packages Reporter: Dominik Kolowski <dkolowski>
Component: Individual Port(s)Assignee: Rusmir Dusko <nemysis>
Status: Closed FIXED    
Severity: Affects Many People Flags: dkolowski: maintainer-feedback? (nemysis)
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Makefile patch for misc/mc none

Description Dominik Kolowski 2014-09-19 09:57:00 UTC
Created attachment 147464 [details]
Makefile patch for misc/mc

Makefile of port misc/mc does incorrect substitution of ZIP variable and sets its value to an unzip command. It causes issues in operation of some mc modules that depend on zip archiver.  Since there is no port-wide definition of ZIP-CMD variable it should be set properly in Makefile.
Comment 1 Bugzilla Automation freebsd_committer 2014-09-19 09:57:00 UTC
Auto-assigned to maintainer nemysis@FreeBSD.org
Comment 2 commit-hook freebsd_committer 2014-09-23 22:50:30 UTC
A commit references this bug:

Author: nemysis
Date: Tue Sep 23 22:49:50 UTC 2014
New revision: 369133
URL: http://svnweb.freebsd.org/changeset/ports/369133

Log:
  - Update to 4.8.13, announce message is here:

      http://www.midnight-commander.org/wiki/NEWS-4.8.13

  - Use ZIP=${ZIP_CMD} instead of ZIP=${UNZIP_CMD} [1]
  - Change patch files/patch-lib__tty__win, changed by upstream
  - Remove obsolete patch files/patch-mc-wrapper

  PR:		193766
  Submitted by:	Dominik Kows <dkolowski@gmail.com> [1]

Changes:
  head/misc/mc/Makefile
  head/misc/mc/distinfo
  head/misc/mc/files/patch-lib__tty__win.c
  head/misc/mc/files/patch-mc-wrapper
  head/misc/mc/pkg-plist
Comment 3 Dominik Kolowski 2014-09-24 17:34:20 UTC
(In reply to commit-hook from comment #2)
> A commit references this bug:
> 
> Author: nemysis
> Date: Tue Sep 23 22:49:50 UTC 2014
> New revision: 369133
> URL: http://svnweb.freebsd.org/changeset/ports/369133
> 
>   PR:		193766
>   Submitted by:	Dominik Kows <dkolowski@gmail.com> [1]
> 

My name in commit information is incorrect - it should be "Kolowski" (without special, language specific letters) and not "Kows". If it's still possible to fix that, than it would be nice, if not then just let it be.
Comment 4 Rusmir Dusko freebsd_committer 2014-09-24 21:29:30 UTC
Sorry not possible now, this is commit message, but email address is correct.