Bug 193771

Summary: www/squidguard depreciated warning with squid 3.4
Product: Ports & Packages Reporter: adrik
Component: Individual Port(s)Assignee: Guido Falsi <madpilot>
Status: Closed FIXED    
Severity: Affects Many People Flags: adrik: maintainer-feedback? (madpilot)
Priority: ---    
Version: Latest   
Hardware: amd64   
OS: Any   
Attachments:
Description Flags
Squidguard 1.4 helper protocol patch. none

Description adrik 2014-09-19 14:24:15 UTC 
Created attachment 147465 [details]
Squidguard 1.4 helper protocol patch.

Using squidguard with the current squid port, version 3.4.x, a warning 'UPGRADE WARNING: URL rewriter reponded with garbage' is generated by squid in cache.log, every time a url is blocked or redirected.
This is caused by squidguard using the old squid 2.7 redirector protocol.

A patch for squidguard 1.4 and 1.5 beta is available at the squidcache site.
See squid bug report 3978, http://bugs.squid-cache.org/show_bug.cgi?id=3978,  for more information.
Since squid 3.4.x is the only supported version by FreeBSD, this patch should be applied to the www/squidguard port.
The proposed patch is attached.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-09-19 14:24:15 UTC 
Auto-assigned to maintainer madpilot@FreeBSD.org
Comment 2 Guido Falsi freebsd_committer freebsd_triage 2014-09-19 16:14:03 UTC 
Thanks for this report and patch.

You are definitely right. The patch lookd good, I'm going to perform some testing and commit it soon.
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2014-09-19 21:33:49 UTC 
Committed! Thanks.
Comment 4 commit-hook freebsd_committer freebsd_triage 2014-09-19 21:34:12 UTC 
A commit references this bug:

Author: madpilot
Date: Fri Sep 19 21:33:28 UTC 2014
New revision: 368602
URL: http://svnweb.freebsd.org/changeset/ports/368602

Log:
  - Import patch from upstream to allow squidguard to work correctly
    with squid 3.4 [1]
  - Put back the option to choose on which squid version to depend,
    which also controls if the above patch is applied, to allow using
    squid33 until it expires
  - While here, take advantage of option helpers to simplify Makefile
    a little
  - Canonicalize patch filenames

  PR:		193771 [1]
  Submitted by:	adrik@salesmanager.nl

Changes:
  head/www/squidguard/Makefile
  head/www/squidguard/files/extrapatch-squid34
  head/www/squidguard/files/patch-sample_sample.conf.in
  head/www/squidguard/files/patch-samples__sample.conf.in
  head/www/squidguard/files/patch-src__main.c
  head/www/squidguard/files/patch-src__sgDb.c
  head/www/squidguard/files/patch-src_main.c
  head/www/squidguard/files/patch-src_sgDB.c