Bug 193785

Summary: [patch]: devel/p5-PatchReader: fix new file detection in SVN patches
Product: Ports & Packages Reporter: Marcus von Appen <mva>
Component: Individual Port(s)Assignee: Marcus von Appen <mva>
Status: Closed FIXED    
Severity: Affects Only Me CC: pi, toni.viemero
Priority: --- Keywords: patch
Version: LatestFlags: toni.viemero: maintainer-feedback+
Hardware: Any   
OS: Any   
URL: https://rt.cpan.org/Public/Bug/Display.html?id=94181
See Also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=399391
Bug Depends on:    
Bug Blocks: 190724    
Attachments:
Description Flags
Parser patch
none
Console test script none

Description Marcus von Appen freebsd_committer freebsd_triage 2014-09-20 07:27:43 UTC 
Created attachment 147496 [details]
Parser patch

PatchReader eats up new file additions in the Raw parser due to several wrong regexp matchers. 

The attached patch fixes fixes

* new file start marks 
* new file end marks
* new file filename detection

The misbehaviour can be seen in the parser output for the attachments mentioned in bug 190724.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-09-20 07:27:43 UTC 
Maintainer CC'd
Comment 2 Marcus von Appen freebsd_committer freebsd_triage 2014-09-20 07:28:51 UTC 
Created attachment 147497 [details]
Console test script

Simple test script for the parser
Comment 3 Marcus von Appen freebsd_committer freebsd_triage 2014-09-20 07:32:51 UTC 
Added reports from other systems for this issue.
Comment 4 Toni Viemerö 2014-09-20 09:25:46 UTC 
Looks fine to me. Apparently Eclipse have tried and tested properly.
Comment 5 Marcus von Appen freebsd_committer freebsd_triage 2014-09-21 17:00:35 UTC 
Committed, thanks for the quick feedback.