Summary: | Uses/python.mk: PYDISTUTILS_EGGINFODIR got expanded into wrong dir because of staging | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Gleb Popov <arrowd> | ||||||
Component: | Ports Framework | Assignee: | Marcus von Appen <mva> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Some People | CC: | portmgr, python | ||||||
Priority: | --- | Keywords: | patch | ||||||
Version: | Latest | Flags: | mva:
exp-run+
|
||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
Attachments: |
|
Description
Gleb Popov
2014-09-21 14:29:05 UTC
Created attachment 147938 [details]
Proper egginfo fix, needs an exp-run
Your attached patch seems to be wrong. We already set
PYDISTUTILS_EGGINFODIR?=${STAGEDIR}${PYTHONPREFIX_SITELIBDIR}
Rather than PYDISTUTILS_EGGINFODIR, the replacement in
add-plist-egginfo:
...
${ECHO_CMD} ${PYDISTUTILS_EGGINFODIR:S;^${STAGEDIR}${PYTHONBASE}/;;}/${egginfo}/$${f} >> ${TMPPLIST};
is wrong, since it assumes PREFIX == PYTHONBASE. This however is not true for a custom prefix, so the line should be changed to
${ECHO_CMD} ${PYDISTUTILS_EGGINFODIR:S;^${STAGEDIR}${PREFIX}/;;}/${egginfo}/$${f} >> ${TMPPLIST};
portmgr@: please exp-run attachment 147938 [details].
6yearold: Can you give my patch another try? It works for me.
Added python@ and portmgr@ in CC (In reply to Marcus von Appen from comment #2) > portmgr@: please exp-run attachment 147938 [details]. > > 6yearold: Can you give my patch another try? It works for me. Yup, seems to work. Now i'm able to install devel/tortoisehg into custom PREFIX. bugzilla seems buggy, this bug wasn't assigned to portmgr (In reply to Antoine Brodin from comment #5) > bugzilla seems buggy, this bug wasn't assigned to portmgr No, I did not reassign it but added portmgr to the CC... no regression during the exp-run A commit references this bug: Author: mva Date: Tue Oct 7 16:51:21 UTC 2014 New revision: 370366 URL: https://svnweb.freebsd.org/changeset/ports/370366 Log: - Do not blindly assume PREFIX to be the same as PYTHONBASE, when creating the egg-info entries for the plist PR: 193811 Reported by: 6yearold@gmail.com Exp-run by: antoine@ With hat: python@ Changes: head/Mk/Uses/python.mk Committed in ports r370366. Thanks for reporting and testing! And we also need to close it... |