Bug 193821
| Summary: | multimedia/libquvi: add LUAJIT option | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Jan Beich <jbeich> | ||||||||
| Component: | Individual Port(s) | Assignee: | Po-Chuan Hsieh <sunpoet> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | Keywords: | patch | ||||||||
| Priority: | --- | ||||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 193822 | ||||||||||
| Attachments: |
|
||||||||||
Auto-assigned to maintainer sunpoet@FreeBSD.org Created attachment 147537 [details]
|poudriere testport| log (9.3R i386)
Created attachment 147538 [details]
|poudriere testport| log (10.0R amd64, LUAJIT=on)
Before switching default value keep in mind consumers that also link against Lua e.g., multimedia/mpv. In such cases default should be in sync. However, according to FreshPorts only a few ports depend on libquvi by default and neither has USES=Lua. Bug 193822 comment 4 has an example stacktrace after mixing Lua implementations. Here's a list of LIB_DEPENDS=libquvi.so consumers in ports tree. Only mpv has USES=lua in Makefile or from dependency. It should be safe to turn on LUAJIT by default together with bug 193822. multimedia/cclive multimedia/mpv multimedia/quvi multimedia/totem-pl-parser multimedia/ffmpeg and multimedia/mplayer2 also support libquvi but not exposed in the ports. If exposed via option ffmpeg may cause a problem not by itself but by whatever depends on it e.g., multimedia/vlc. In such cases one may consider adding LUAJIT option there as well. A commit references this bug: Author: sunpoet Date: Wed Oct 1 20:06:57 UTC 2014 New revision: 369750 URL: https://svnweb.freebsd.org/changeset/ports/369750 Log: - Add LUAJIT option PR: ports/193821 Submitted by: Jan Beich <jbeich@vfemail.net> Changes: head/multimedia/libquvi/Makefile Committed. Thanks! |
Created attachment 147536 [details] v1 Tested against multimedia/mpv. Leaving default as is. If you feel adventurous follow devel/love: # lang/luajit is BROKEN elsewhere OPTIONS_DEFAULT_i386= LUAJIT OPTIONS_DEFAULT_amd64= LUAJIT