Bug 193849
| Summary: | www/xpi-conkeror builds from very old source code | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | r004 <roo4.id> | ||||||||||||
| Component: | Individual Port(s) | Assignee: | Ashish SHUKLA <ashish> | ||||||||||||
| Status: | Closed FIXED | ||||||||||||||
| Severity: | Affects Many People | CC: | arved, jbeich | ||||||||||||
| Priority: | Normal | Flags: | roo4.id:
maintainer-feedback-
|
||||||||||||
| Version: | Latest | ||||||||||||||
| Hardware: | amd64 | ||||||||||||||
| OS: | Any | ||||||||||||||
| Attachments: |
|
||||||||||||||
Auto-assigned to maintainer ashish@FreeBSD.org if we use http://repo.or.cz/w/conkeror.git?a=snapshot;h=master;sf=tgz' -O conkeror-master.tar.gz in the Makefile we would have the latest snapshot at any time. Created attachment 147601 [details]
update to 20140812 snapshot
git master is a moving target, better use a commit hash or tag so distfile
checksum wouldn't change over time. Here's a trick.
Created attachment 147602 [details] update to 20140812 snapshot Doh, the following URL is easier to work with. http://repo.or.cz/w/conkeror.git/snapshot/d87d0b8.tar.gz Dear Jan; Is you diff the final and production ready version? also your are right about the source link. thank you Created attachment 147610 [details] |poudriere testport -P| log (9.3R i386) It seems the Porter's Handbook agrees with portlint(1) but I cannot find actual rationale. However, looking at DISTVERSION implementation it should work fine with both set. And attached smoke test log confirms my conjecture. $ portlint -C FATAL: Makefile: either PORTVERSION or DISTVERSION must be specified, not both. 1 fatal error and 0 warnings found. Porter's Handbook says: > Only one of PORTVERSION and DISTVERSION can be set at a time. If DISTVERSION does not derive a correct PORTVERSION, do not use DISTVERSION, set PORTVERSION to the right value and set DISTNAME with PORTNAME with either some computation of PORTVERSION or the verbatim upstream version. # Mk/bsd.port.mk has .if defined(PORTVERSION) .if ${PORTVERSION:M*[-_,]*}x != x IGNORE= PORTVERSION ${PORTVERSION} may not contain '-' '_' or ',' .endif DISTVERSION?= ${PORTVERSION:S/:/::/g} .elif defined(DISTVERSION) PORTVERSION= ${DISTVERSION:tl:C/([a-z])[a-z]+/\1/g:C/([0-9])([a-z])/\1.\2/g:C/:(.)/\1/g:C/[^a-z0-9+]+/./g} .endif The build log also hints about CHANGES from 20140922. It's up to the maintainer to decide when to pull the plug on partial updates. ===> Building package for conkeror-20140812 pkg-static: Warning: @dirrm is deprecated please use @dir while ====>> Files or directories left over: @dirrm /prefix is a false positive from PREFIX!=LOCALBASE, likely either bsd.port.mk or pkg(8) bug. Created attachment 147614 [details]
|poudriere testport -P| log (10.0R amd64, FIREFOX=on)
What is the difference between using xulrunner from firefox port (which port is that exactly; does it mean installing the whole firefox and thus more dep.) and using libxul? A commit references this bug: Author: ashish Date: Fri Oct 3 08:22:41 UTC 2014 New revision: 369874 URL: https://svnweb.freebsd.org/changeset/ports/369874 Log: - Update to latest HEAD PR: 193849 Changes: head/www/xpi-conkeror/Makefile head/www/xpi-conkeror/distinfo head/www/xpi-conkeror/pkg-plist Hi roo4.id, I've committed the update. I'm not able to reproduce the warnings which I get in redports, nor I've any fix for that. So, I've committed the port update which I planned. HTH |
Created attachment 147572 [details] UNCOMPLETE diff patch for Makefile According to conkeror web site there is a very more recent source code for conkeror but the port maintainers just bump up the version and it actually build from tyhe past source codes. The main maintainer **ashish** did the favour of making some adjustment. but according to him it is not completely safe. PLZ someone take it from here and finish the job thanks