Bug 193916

Summary: ftp/vsftpd-ext: Update to 3.0.2, Enable STAGE support
Product: Ports & Packages Reporter: Xu Jing <xjflyttp>
Component: Individual Port(s)Assignee: Kurt Jaeger <pi>
Status: Closed FIXED    
Severity: Affects Only Me CC: pi
Priority: --- Keywords: patch
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
diff base on ports tree r366889, because delete by r366890
none
use @sample, USERS=ftp GROUPS=ftp, trim @dirrm
none
update to 3.0.2 none

Description Xu Jing 2014-09-25 06:16:05 UTC
Created attachment 147663 [details]
diff base on ports tree r366889, because delete by r366890

http://www.freshports.org/ftp/vsftpd-ext/
DEPRECATED: Not staged
This port expired on: 2014-08-31
Comment 1 Kurt Jaeger freebsd_committer freebsd_triage 2014-09-25 18:52:03 UTC
(In reply to Xu Jing from comment #0)
> Created attachment 147663 [details]
> diff base on ports tree r366889, because delete by r366890

Thanks. I tested it and it builds on poudriere (10.0-amd64, 9.1-amd64 and 8.4-i386). I have a few questions:

- Is there a reason 2.3.5 is used and not 3.0.2 ?
- Can you use @sample in pkg-plist instead of exec/unexec ? See

https://www.freebsd.org/doc/en/books/porters-handbook/plist-keywords.html#plist-keywords-sample

  for details.
- pkg-plist uses some shell script to detect/create users.
  Would using /usr/ports/UIDs etc work ? With USERS=ftp GROUPS=ftp ?
- Can you check if you can trim your @dirrm in pkg-plist ? See

https://lists.freebsd.org/pipermail/svn-ports-all/2014-September/074391.html

  for details on the changes related to @dirrm.
Comment 2 Xu Jing 2014-09-26 07:56:43 UTC
Created attachment 147683 [details]
use @sample, USERS=ftp GROUPS=ftp, trim @dirrm

use @sample, USERS=ftp GROUPS=ftp, trim @dirrm

I can't complie with 3.0.2, author change complie *.c mode in Makefile, only patch for 2.3.5

about 3.0.2 fail, I'm check problem in this line, nothing *.c file be complie, but continue link for vsftpd
================
OBJS	=	$(patsubst %.c,%.o,$(wildcard *.c))
=================

cc -o vsftpd -fPIE -pie -Wl,-z,relro -Wl,-z,now   `./vsf_findlibs.sh`
egrep: tcpwrap.o: No such file or directory
egrep: sysdeputil.o: No such file or directory
egrep: ssl.o: No such file or directory
/usr/lib/Scrt1.o: In function `_start':
/usr/src/lib/csu/amd64/crt1.c:(.text+0x19f): undefined reference to `main'
cc: error: linker command failed with exit code 1 (use -v to see invocation)
*** [vsftpd] Error code 1
Comment 3 Xu Jing 2014-09-26 09:21:00 UTC
Created attachment 147684 [details]
update to 3.0.2

I'm find 3.0.2 problem is need gmake for support "$(patsubst %.c,%.o,$(wildcard *.c))" syntax, now upgrade to 3.0.2,
thanks.
Comment 4 commit-hook freebsd_committer freebsd_triage 2014-09-26 20:44:16 UTC
A commit references this bug:

Author: pi
Date: Fri Sep 26 20:43:31 UTC 2014
New revision: 369343
URL: http://svnweb.freebsd.org/changeset/ports/369343

Log:
  ftp/vsftpd-ext: resurrect, upgrade 2.3.5 -> 3.0.2, stagify

  Extended build of vsftpd with additional features.

  WWW: http://vsftpd.devnet.ru/eng/

  PR:		193916
  Submitted by:	Xu Jing <xjflyttp@gmail.com>

Changes:
  head/MOVED
  head/ftp/Makefile
  head/ftp/vsftpd-ext/
  head/ftp/vsftpd-ext/Makefile
  head/ftp/vsftpd-ext/distinfo
  head/ftp/vsftpd-ext/pkg-plist
Comment 5 Kurt Jaeger freebsd_committer freebsd_triage 2014-09-26 20:46:23 UTC
Committed, thanks!