Bug 193933

Summary:	getpatch does'nt know how to fetch multiple patches from a PR
Product:	Services	Reporter:	Thierry Thomas <thierry>
Component:	Bug Tracker	Assignee:	Sofian Brabez <sbz>
Status:	Closed FIXED
Severity:	Affects Some People	CC:	bugmeister, gonzo
Priority:	---
Version:	unspecified
Hardware:	Any
OS:	Any
See Also:	https://reviews.freebsd.org/D14550

Description Thierry Thomas freebsd_committer

2014-09-25 19:19:47 UTC

For example, see PR ports/193920: the maintainer submitted several patches with the same name, and each of them supersedes the previous one.

Trying to detach the patch with getpatch:

$ /usr/ports/Tools/scripts/getpatch 193920
[+] Fetching patch for pr /193920
[+] patch-uTox.diff created
[+] patch-uTox.diff created
[+] patch-uTox.diff created

$ ll patch-uTox.diff
-rw-r--r--  1 thierry  wheel  1169 25 sep 21:13 patch-uTox.diff

It should ignore the obsoleted patches - if possible.

Comment 1 Marcus von Appen freebsd_committer

2014-09-25 19:27:49 UTC

Over to sbz@, who maintains the script - bugmeister kept in CC for input, if necessary.

Comment 2 Oleksandr Tymoshenko freebsd_committer

2018-03-01 06:42:11 UTC

I submitted patch for review that makes getpatch skip over obsolete attachments

Comment 3 Oleksandr Tymoshenko freebsd_committer

2018-09-06 17:53:15 UTC

Patch committed as ports r470568