Bug 193940

Summary: [EXP-RUN] Request For ASLR Patches
Product: Ports & Packages Reporter: Sean Bruno <sbruno>
Component: Ports FrameworkAssignee: Sean Bruno <sbruno>
Status: Closed FIXED    
Severity: Affects Many People CC: des, emaste, portmgr, sbruno, shawn.webb, tablosazi.farahan
Priority: ---    
Version: Latest   
Hardware: amd64   
OS: Any   
Attachments:
Description Flags
vanilla
none
patched with ASLR on
none
patched without ASLR none

Description Sean Bruno freebsd_committer freebsd_triage 2014-09-26 09:41:23 UTC
Please configure 11-current for an EXP-RUN containing the ASLR patches in review D473 and monitor build times and build failure of ports.

https://reviews.freebsd.org/D473
Comment 1 Antoine Brodin freebsd_committer freebsd_triage 2014-09-28 09:29:56 UTC
Take for exp-run ,  it will take around a week.
Comment 2 Antoine Brodin freebsd_committer freebsd_triage 2014-09-29 19:48:43 UTC
ok,  which of those 3 do you want to compare:

1) D473 with options PAX_ASLR and options PAX_SYSCTLS
2) D473 without options PAX_ASLR and options PAX_SYSCTLS
3) vanilla kernel
Comment 3 Dag-Erling Smørgrav freebsd_committer freebsd_triage 2014-10-02 08:33:04 UTC
Can you do all three?  Unless the hardware is identical to the official package builder, in which case we already have a baseline.
Comment 4 Shawn Webb 2014-10-04 13:46:08 UTC
All three would be best. Can you also monitor the build time of world+kernel with the patches? You need to build/install at least the kernel anyways, so getting metrics of the build would also kill two birds with one stone.
Comment 5 Antoine Brodin freebsd_committer freebsd_triage 2014-10-04 15:18:10 UTC
Created attachment 147971 [details]
vanilla
Comment 6 Antoine Brodin freebsd_committer freebsd_triage 2014-10-04 15:18:51 UTC
Created attachment 147972 [details]
patched with ASLR on
Comment 7 Antoine Brodin freebsd_committer freebsd_triage 2014-10-04 15:19:22 UTC
Created attachment 147973 [details]
patched without ASLR
Comment 8 Antoine Brodin freebsd_committer freebsd_triage 2014-10-04 15:24:09 UTC
I attached the build times for the 3 scenarios, the precision is 1 second.

There were 2 new reproducible failures with ASLR on:

devel/plan9port
lang/phantomjs

Failure logs:

http://package23.nyi.freebsd.org/data/head-amd64-default-r272245D473PACKAGEASLR/2014-10-01_06h05m53s/logs/errors/phantomjs-1.9.2_3.log
http://package23.nyi.freebsd.org/data/head-amd64-default-r272245D473PACKAGEASLR/2014-10-01_06h05m53s/logs/errors/plan9port-20140306_1.log

Those failure do not happen without ASLR.
Comment 9 Shawn Webb 2014-10-04 16:10:35 UTC
(In reply to Antoine Brodin from comment #8)
> I attached the build times for the 3 scenarios, the precision is 1 second.
> 
> There were 2 new reproducible failures with ASLR on:
> 
> devel/plan9port
> lang/phantomjs
> 
> Failure logs:
> 
> http://package23.nyi.freebsd.org/data/head-amd64-default-
> r272245D473PACKAGEASLR/2014-10-01_06h05m53s/logs/errors/phantomjs-1.9.2_3.log
> http://package23.nyi.freebsd.org/data/head-amd64-default-
> r272245D473PACKAGEASLR/2014-10-01_06h05m53s/logs/errors/plan9port-20140306_1.
> log
> 
> Those failure do not happen without ASLR.

Thank you! So that tells us that having ASLR on gives us better performance than without ASLR compiled in at all. A savings of 7984 seconds, just over two hours.
Comment 10 Antoine Brodin freebsd_committer freebsd_triage 2014-10-04 16:12:04 UTC
I don't think so,  building phantomjs takes around 2 hours when it succeeds ;-)
Comment 11 Shawn Webb 2014-10-04 16:13:48 UTC
Ah, so we're probably right in line with performance, then.
Comment 12 Sean Bruno freebsd_committer freebsd_triage 2015-01-03 02:56:20 UTC
EXP-RUN done as requested.  New bug request should be submitted if desired.
Comment 13 vali gholami 2017-12-17 07:12:09 UTC
MARKED AS SPAM