Bug 19397
| Summary: | Diablo port is outdated and buggy | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | des <des> | ||||
| Component: | Individual Port(s) | Assignee: | freebsd-ports (Nobody) <ports> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | ||||||
| Priority: | Normal | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
State Changed From-To: open->closed New port has been committed. |
The current Diablo port (news/diablo) is severely outdated and buggy: 1) the version of Diablo it builds is v. 1.15, dated February 1998; the current release of Diablo is 2.2-REL, dated May 2000. 2) the master site in the Makefile is no longer correct, since Matt Dillon no longer maintains 3) the Makefile has /usr/local hardcoded in several places and assumes that xmake is located in ${PREFIX}/bin, and will therefore not build or install properly if PREFIX or LOCALBASE is set to something else than /usr/local. 4) the version of Diablo it builds has its own strlcpy() with a different argument list than the one in libc; therefore the build will fail on any FreeBSD system recent enough to have strlcpy() (3.3 or newer). 5) the description of Diablo in pkg/DESCR is incorrect even for the obsolete version that the port actually installs, since 1.15 was the first version to include dreaderd and was therefore no longer "strictly a backbone news transit system". Fix: Apply the patch included below. Notes: 1) I've put myself up as maintainer since the listed maintainer hasn't touched the port since 1997 and doesn't respond to mail about the port. (oh well, there goes my resolve not to get involved in the ports collection...) 2) I don't actually run a news server, so I can only vouch that the port builds and installs properly, not that it works. 3) the patch makes some other improvements to the port, such as patching the XMakefile so Diablo will install and run in ${PREFIX}/news without the need for a /news symlink, and putting the post-install notes in pkg/MESSAGE so they'll show up when you install the package. 4) Also note that I think the NO_PACKAGE restriction can be lifted, since I don't think Diablo needs the 'news' user to have a valid shell or home directory, but I haven't verified this, so I've left NO_PACKAGE in place. How-To-Repeat: # cd /usr/ports/news/diablo # make install PREFIX=/tmp/diablo The build will fail for want of xmake; if xmake is where the Makefile expects it to be, it will fail due to the strlcpy() conflict, unless your system is old enough, in which case I *think* it will succeed (though I haven't actually verified this) except for setting the news user's home directory wrong.