Bug 194017

Summary: systat -altqs flag
Product: Base System Reporter: David CARLIER <david.carlier>
Component: binAssignee: freebsd-bugs (Nobody) <bugs>
Status: New ---    
Severity: Affects Only Me CC: pfg
Priority: ---    
Version: CURRENT   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Final none

Description David CARLIER 2014-09-29 18:37:45 UTC
In similar manner than DragonflyBSD, displaying ALTQ statistics with sys tat
Patches are available here

https://github.com/HardenedBSD/hardenedBSD/commit/add9540e6f2666b4522c6b70b629f1e1595d16a4
https://github.com/HardenedBSD/hardenedBSD/commit/0ca47d471b6d34ab3344bc6745b5d409c0a9ea5b
Comment 1 Pedro F. Giffuni freebsd_committer 2014-09-29 19:57:11 UTC
(In reply to David CARLIER from comment #0)
> In similar manner than DragonflyBSD, displaying ALTQ statistics with sys tat
> Patches are available here
> 
...
> https://github.com/HardenedBSD/hardenedBSD/commit/
> 0ca47d471b6d34ab3344bc6745b5d409c0a9ea5b

Just a note:

This change adds a file (altqs.c) which in the DragonFly commit is based on ifstat.c.

http://gitweb.dragonflybsd.org/dragonfly.git/commitdiff/aa0a803a57c7119e5b39d166a1bc779fb1917014

We have our own ifstat.c with local changes so the correct way to port this is to do a repository copy and merge the altq specific changes.
Comment 2 David CARLIER 2014-09-29 20:51:51 UTC
Fair point ...
Does it suit better ?

https://github.com/HardenedBSD/hardenedBSD/commit/7c2ed2ab66ef54f12508e060d17c92c9c6b7acd7
Comment 3 Pedro F. Giffuni freebsd_committer 2014-09-29 21:18:49 UTC
(In reply to David CARLIER from comment #2)
> Fair point ...
> Does it suit better ?
> 
> https://github.com/HardenedBSD/hardenedBSD/commit/
> 7c2ed2ab66ef54f12508e060d17c92c9c6b7acd7

So now you have merged altqs.c into ifstat.c making it diverge from DragonFly :(.

Note that this makes more difficult to track fixes from Dragonfly, and there was already one upstream bug fix commit to Dragonfly's altqs.c.
Comment 4 David CARLIER 2014-09-29 22:50:44 UTC
Created attachment 147812 [details]
Final