Bug 194030

Summary: net/libnatpmp: update to 20140401
Product: Ports & Packages Reporter: Jan Beich <jbeich>
Component: Individual Port(s)Assignee: Chris Rees <crees>
Status: Closed FIXED    
Severity: Affects Only Me CC: crees, gaod
Priority: --- Keywords: patch-ready
Version: LatestFlags: crees: maintainer-feedback? (gaod)
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 194029    
Attachments:
Description Flags
update
none
|poudriere testport -P| log (9.3R i386)
none
update, v1.1 none

Description Jan Beich freebsd_committer freebsd_triage 2014-09-30 08:16:37 UTC 
Created attachment 147823 [details]
update

- update
- clarify LICENSE to be BSD3CLAUSE like net/miniupnpc
- replace patch-Makefile with a simple MAKE_(ARGS|ENV) override
- drop redundant -fPIC
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-09-30 08:16:37 UTC 
Maintainer CC'd
Comment 2 Jan Beich freebsd_committer freebsd_triage 2014-09-30 08:18:05 UTC 
Created attachment 147824 [details]
|poudriere testport -P| log (9.3R i386)
Comment 3 Jan Beich freebsd_committer freebsd_triage 2014-09-30 10:15:05 UTC 
Created attachment 147832 [details]
update, v1.1

Add a post-patch workaround to avoid breaking consumers as declspec.h is not installed (unlike in net/miniupnpc).

In file included from natpmp.c:17:
/usr/local/include/natpmp.h:54:10: fatal error: 'declspec.h' file not found
#include "declspec.h"
         ^
1 error generated.
Comment 4 Jan Beich freebsd_committer freebsd_triage 2014-10-01 17:47:55 UTC 
Before bugzilla workflow is documented it'd help if you explain maintainer-feedback- (minus'd) when set by someone other than the current maintainer. Is this an attempt to forcefully claim the port? Otherwise, it's unclear from whom Approval is requested.
Comment 5 Chris Rees freebsd_committer freebsd_triage 2014-10-01 18:19:28 UTC 
Uh... I've messed up the feedback bit- not used to bz :(  How can I fix it now??
Comment 6 John Marino freebsd_committer freebsd_triage 2014-11-01 15:21:49 UTC 
This is clearly a case of a maintainer timeout.  The patch looks good, it comes with a good poudriere log.  Maintainer approval is no longer required, I'm promoting this patch-ready pool.
Comment 7 Hung-Yi Chen 2014-12-14 21:17:37 UTC 
I'm sorry for the late reply.

The patch seems okay.

Please commit it.
Comment 8 commit-hook freebsd_committer freebsd_triage 2014-12-19 17:22:01 UTC 
A commit references this bug:

Author: crees
Date: Fri Dec 19 17:21:38 UTC 2014
New revision: 374955
URL: https://svnweb.freebsd.org/changeset/ports/374955

Log:
  - update
  - clarify LICENSE to be BSD3CLAUSE like net/miniupnpc
  - replace patch-Makefile with a simple MAKE_(ARGS|ENV) override
  - drop redundant -fPIC

  PR:		ports/194030
  Submitted by:	Jan Beich
  Approved by:	Hung-Yi Chen (maintainer)

Changes:
  head/net/libnatpmp/Makefile
  head/net/libnatpmp/distinfo
  head/net/libnatpmp/files/
Comment 9 Chris Rees freebsd_committer freebsd_triage 2014-12-19 17:22:32 UTC 
Committed.  Thanks!
Comment 10 Jan Beich freebsd_committer freebsd_triage 2014-12-20 01:08:32 UTC 
Why -fPIC change was excluded?
Comment 11 commit-hook freebsd_committer freebsd_triage 2015-02-01 16:04:34 UTC 
A commit references this bug:

Author: jbeich
Date: Sun Feb  1 16:04:22 UTC 2015
New revision: 378250
URL: https://svnweb.freebsd.org/changeset/ports/378250

Log:
  Drop redundant -fPIC from CFLAGS

  PR:		194030 (followup)
  Approved by:	bapt (mentor)

Changes:
  head/net/libnatpmp/Makefile