Bug 194036

Summary: net/libutp: update to 0.20130514 (before API change from uTorrent 3.4)
Product: Ports & Packages Reporter: Jan Beich <jbeich>
Component: Individual Port(s)Assignee: Mikhail Teterin <mi>
Status: Closed FIXED    
Severity: Affects Only Me CC: crees, freebsd-2024
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
See Also: http://trac.transmissionbt.com/ticket/5888
Bug Depends on:    
Bug Blocks: 194029, 196612    
Attachments:
Description Flags
update
none
|poudriere testport -P| log (9.3R i386) none

Description Jan Beich freebsd_committer freebsd_triage 2014-09-30 10:36:13 UTC
Created attachment 147833 [details]
update

The most recent version of libutp breaks Transmission due to API change.

peer-io.c:520:32: error: variable has incomplete type 'struct UTPFunctionTable'
static struct UTPFunctionTable utp_function_table = {
                               ^
peer-io.c:520:15: note: forward declaration of 'struct UTPFunctionTable'
static struct UTPFunctionTable utp_function_table = {
              ^
peer-io.c:575:32: error: variable has incomplete type 'struct UTPFunctionTable'
static struct UTPFunctionTable dummy_utp_function_table = {
                               ^
peer-io.c:520:15: note: forward declaration of 'struct UTPFunctionTable'
static struct UTPFunctionTable utp_function_table = {
              ^
peer-io.c:641:9: warning: implicit declaration of function 'UTP_SetSockopt' is
      invalid in C99 [-Wimplicit-function-declaration]
        UTP_SetSockopt (utp_socket, SO_RCVBUF, UTP_READ_BUFFER_SIZE);
        ^
peer-io.c:643:9: warning: implicit declaration of function 'UTP_SetCallbacks' is
      invalid in C99 [-Wimplicit-function-declaration]
        UTP_SetCallbacks (utp_socket,
        ^
peer-io.c:648:13: warning: implicit declaration of function 'UTP_Connect' is invalid
      in C99 [-Wimplicit-function-declaration]
            UTP_Connect (utp_socket);
            ^
peer-io.c:810:9: warning: implicit declaration of function 'UTP_Close' is invalid in
      C99 [-Wimplicit-function-declaration]
        UTP_Close (io->utp_socket);
        ^
peer-io.c:1233:17: warning: implicit declaration of function 'UTP_RBDrained' is
      invalid in C99 [-Wimplicit-function-declaration]
                UTP_RBDrained (io->utp_socket);
                ^
peer-io.c:1278:13: warning: implicit declaration of function 'UTP_Write' is invalid
      in C99 [-Wimplicit-function-declaration]
            UTP_Write (io->utp_socket, howmuch);
            ^
6 warnings and 2 errors generated.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-09-30 10:36:13 UTC
Maintainer CC'd
Comment 2 Jan Beich freebsd_committer freebsd_triage 2014-09-30 10:37:11 UTC
Created attachment 147834 [details]
|poudriere testport -P| log (9.3R i386)
Comment 3 commit-hook freebsd_committer freebsd_triage 2014-09-30 15:45:51 UTC
A commit references this bug:

Author: mi
Date: Tue Sep 30 15:45:00 UTC 2014
New revision: 369640
URL: https://svnweb.freebsd.org/changeset/ports/369640

Log:
  Update from 0.20120526 to 0.20130514.

  PR:		194036
  Submitted by:	Jan Beich

Changes:
  head/net/libutp/Makefile
  head/net/libutp/distinfo
Comment 4 Chris Rees freebsd_committer freebsd_triage 2014-09-30 19:25:13 UTC
Committed by mi.