Bug 194167

Summary: graphics/pixie: Fix build on 8.x/9.x
Product: Ports & Packages Reporter: tkato432
Component: Individual Port(s)Assignee: John Marino <marino>
Status: Closed FIXED    
Severity: Affects Only Me CC: marino
Priority: --- Keywords: needs-qa, patch
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
graphics_pixie.diff
none
graphics_pixie.diff
none
graphics_pixie.diff none

Description tkato432 2014-10-05 18:32:35 UTC 
Created attachment 148007 [details]
graphics_pixie.diff
Comment 1 tkato432 2014-10-18 12:31:03 UTC 
Created attachment 148429 [details]
graphics_pixie.diff
Comment 2 John Marino freebsd_committer freebsd_triage 2014-10-23 15:46:56 UTC 
why the change on lines 61-64?
They don't do anything different and as far as I am concerned the original approach is better.  (e.g. avoid loops if its possible, and this created a loop for no decent reason)
Comment 3 John Marino freebsd_committer freebsd_triage 2014-10-31 14:31:00 UTC 
ping
Comment 4 Antoine Brodin freebsd_committer freebsd_triage 2014-11-11 09:20:03 UTC 
also the patch doesn't fix the build for me
Comment 5 John Marino freebsd_committer freebsd_triage 2015-01-26 07:23:04 UTC 
There's been no response from submitter since mid-november and it doesn't fix the build as advertised (according to antoine) so I'm closing the PR without further action.
Comment 6 John Marino freebsd_committer freebsd_triage 2015-01-26 07:23:51 UTC 
(more accurately there was no response since mid october)
Comment 7 tkato432 2015-01-27 10:00:39 UTC 
Created attachment 152255 [details]
graphics_pixie.diff

It seems this port also doesn't build with 9.x at present.
Comment 8 tkato432 2015-01-27 10:02:03 UTC 
reopen
Comment 9 commit-hook freebsd_committer freebsd_triage 2015-02-06 19:49:04 UTC 
A commit references this bug:

Author: marino
Date: Fri Feb  6 19:48:09 UTC 2015
New revision: 378551
URL: https://svnweb.freebsd.org/changeset/ports/378551

Log:
  graphics/pixie: Fix build on F9

  PR:		194167
  Submitted by:	Ports Fury

Changes:
  head/graphics/pixie/Makefile
  head/graphics/pixie/files/patch-configure
Comment 10 John Marino freebsd_committer freebsd_triage 2015-02-06 19:52:29 UTC 
Thanks.  I removed the unnecessary changes and tested it on FreeBSD 9 successfully.