Bug 194282
| Summary: | [maintainer update] audio/teamspeak3-server to 3.0.11 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | hirner | ||||||
| Component: | Individual Port(s) | Assignee: | Thomas Zander <riggs> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Many People | CC: | lukasz, riggs | ||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Created attachment 148678 [details]
Updated patch
Some proposed changes:
- Un-silence INSTALL* (it's convention these days)
- Remove superfluous lines from Makefile (pkg-message is displayed automatically, brokenness with BATCH is implicitly given by omitting auto-accept in LICENSE_PERMS, PORTREVISION is obsolete with PORTVERSION bump)
- Merge pkg-plist with recent cleanup of pkg-plist which was not part of the submission
Let me know if you approve of these, then I can commit the diff. Thanks!
Guess it's OK, but I don't understand what you have done with the pkg-plist? I generate it semi-automatically for every version. What did you change and why? (In reply to hirner from comment #2) > Guess it's OK, but I don't understand what you have done with the pkg-plist? > I generate it semi-automatically for every version. What did you change and > why? I didn't do much with pkg-plist. There has been a commit by bapt a week ago which is probably the change that you are looking for: ------------------------------------------------------------------------ r371234 | bapt | 2014-10-20 08:35:58 +0200 (Mon, 20 Oct 2014) | 2 lines Cleanup plist ------------------------------------------------------------------------ The only thing I did was merge your diff with the current version of pkg-plist so it is complete and modernise directory handling from your patch (@dirrm(try) is no longer needed). A commit references this bug: Author: riggs Date: Mon Oct 27 06:19:26 UTC 2014 New revision: 371531 URL: https://svnweb.freebsd.org/changeset/ports/371531 Log: - Update to upstream version 3.0.11 - Remove invalid mirror - gcc and libiconv dependencies not needed anymore - WRKSRC has changed ("_" for x86, "-" for amd64) - Correct ownership of /var/log/teamspeak - Un-silence INSTALL* - Remove explicit actions which are handled by ports/pkg automatically - Display pkg-message.in - IGNORE due to license; LICENSE_PERMS does not contain auto-accept PR: 194282 Submitted by: hirner@bitfire.at (maintainer) Reviewed by: riggs Approved by: hirner@bitfire.at (maintainer) Changes: head/audio/teamspeak3-server/Makefile head/audio/teamspeak3-server/distinfo head/audio/teamspeak3-server/pkg-plist |
Created attachment 148161 [details] audio/teamspeak3-server 3.0.10.3 to 3.0.11 diff Update to 3.0.11 * removed invalid mirror * gcc and libiconv dependencies not needed anymore * WRKSRC has changed ("_" for x86, "-" for amd64) * bug fix: set correct ownership of /var/log/teamspeak * some changed files