Bug 194317
| Summary: | [PATCH] graphics/electrix: Fix stage-qa, use options helpers | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Jason E. Hale <jhale> | ||||
| Component: | Individual Port(s) | Assignee: | Jason E. Hale <jhale> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | CC: | olivierd | ||||
| Priority: | --- | Keywords: | patch | ||||
| Version: | Latest | Flags: | jhale:
maintainer-feedback?
(olivierd) |
||||
| Hardware: | i386 | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Auto-assigned to maintainer olivierd@FreeBSD.org Patch seems good, you can commit changes. A commit references this bug: Author: jhale Date: Mon Oct 27 23:36:31 UTC 2014 New revision: 371610 URL: https://svnweb.freebsd.org/changeset/ports/371610 Log: - Fix stage-qa error where STAGEDIR was being referenced by the binary by setting up MAKE_ENV instead of passing STAGEDIR through PREFIX - Respect CC, CFLAGS, LDFLAGS, and MAKE_JOBS - Strip binaries - Convert USE_BZIP2 to USES - Use options helpers (this also fixes a problem where LIB_DEPENDS was being over-ridden in the PDF option, effectively cancelling out the LIB_DEPENDS for the PS option) Note: Did not use <OPT>_CONFIGURE_ENABLE because the configure script only understands --disable-<feature> - Bump PORTREVISION PR: 194317 Approved by: olivierd (maintainer) Changes: head/graphics/electrix/Makefile Committed, thanks! I did change CONFIGURE_ENV to MAKE_ENV since MAKE_ENV already defines CC, CXX, PREFIX, etc. |
Created attachment 148212 [details] electrix patch graphics/electrix errors out on stage-qa because the binary references STAGEDIR. This is due to PREFIX being defined to include STAGEDIR instead on setting it as DESTDIR in the environment. It also does not respect CC, CFLAGS, etc. The attached patch sets up an environment for the waf script to use to fix these issues. While here: - Convert to options helpers - Drop PDF_DESC and PS_DESC because they have standard definitions - Convert USE_BZIP2 and USE_PYTHON to USES - Strip binaries