Bug 194370

Summary: [MAINTAINER] mail/bsfilter: remove @dirrm from pkg-plist
Product: Ports & Packages Reporter: Yasuhiro Kimura <yasu>
Component: Individual Port(s)Assignee: John Marino <marino>
Status: Closed FIXED    
Severity: Affects Some People CC: marino
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Remove @dirrm from pkg-plist.
none
Updated patch. none

Description Yasuhiro Kimura freebsd_committer freebsd_triage 2014-10-15 04:58:59 UTC 
Created attachment 148327 [details]
Remove @dirrm from pkg-plist.

* Remove @dirrm from pkg-plist.
* Pet portlint.
Comment 1 John Marino freebsd_committer freebsd_triage 2014-10-16 08:41:56 UTC 
comment 1)  you can leave this command masked,  you don't need to change it:
${MKDIR} ${STAGEDIR}${EXAMPLESDIR}


comment 2)
use ${COPYTREE_SHARE} for this line:
${CP} -r ${WRKSRC}/${DIR} ${STAGEDIR}${EXAMPLESDIR}/${DIR}

Unless there is concrete justification for using ${CP}, don't use it.

Can you make those changes and resubmit?
Comment 2 Yasuhiro Kimura freebsd_committer freebsd_triage 2014-10-16 23:05:48 UTC 
Created attachment 148382 [details]
Updated patch.

Thank you comments.

I updated patch, so please commit it instead of original one.

Regards.
Comment 3 commit-hook freebsd_committer freebsd_triage 2014-10-18 06:47:46 UTC 
A commit references this bug:

Author: marino
Date: Sat Oct 18 06:47:26 UTC 2014
New revision: 371093
URL: https://svnweb.freebsd.org/changeset/ports/371093

Log:
  mail/bsfilter: Remove @dirrm, unmask cmds, use COPYTREE over CP

  PR:		194370
  submitted by:	maintainer (Yasuhiro KIMURA)

Changes:
  head/mail/bsfilter/Makefile
  head/mail/bsfilter/pkg-plist
Comment 4 John Marino freebsd_committer freebsd_triage 2014-10-18 06:53:33 UTC 
Thanks!