Bug 194565
| Summary: | [patch] x11-toolkits/irrlicht: fix DEBUG option, remove unnecessary dependency, extend LDFLAGS | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Andriy Voskoboinyk <avos> | ||||||||
| Component: | Individual Port(s) | Assignee: | John Marino <marino> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | CC: | marino | ||||||||
| Priority: | --- | ||||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 148605 [details]
patch-irrlicht.diff
update PORTREVISION
I'll take it. I have doubt about the last line that add "-lz". portsmon is showing irrlicht is building everywhere, including head. Why is -lz added? could it be obsolete? will it build without it? (In reply to John Marino from comment #3) > I have doubt about the last line that add "-lz". > > portsmon is showing irrlicht is building everywhere, including head. Why is > -lz added? could it be obsolete? will it build without it? The library has few unresolved symbols, which are visible when -Wl,--no-undefined is added to LDFLAGS (however, they are resolved via sub-dependencies). Also, there is missed dependency to libXxf86vm - I'm not sure, what to do with it (turn it into option + possibly add Xrandr option or just add USE_XORG=x11 xxf86vm) is there a major drawback to 'USE_XORG=x11 xxf86vm' solution? seems okay to me. (In reply to John Marino from comment #5) > is there a major drawback to 'USE_XORG=x11 xxf86vm' solution? seems okay to > me. No, it's ok (this is the default config). I think, that other options (like output via SDL) can be added later (on demand). Created attachment 148942 [details]
patch-irrlicht.diff
Add USE_XORG=x11 xxf86vm
A commit references this bug: Author: marino Date: Sun Nov 2 18:15:21 UTC 2014 New revision: 372081 URL: https://svnweb.freebsd.org/changeset/ports/372081 Log: x11-toolkits/irrlicht: Fix DEBUG option, missing linker symbols * apply NDEBUG=1 when DEBUG is off * Depend on libGL instead of libGLU * Add missing -lX11 -lZ to LDFLAGS * Add USE_XORG= x11 xxf86vm PR: 194565 Submitted by: Andriy Voskoboinyk Changes: head/x11-toolkits/irrlicht/Makefile head/x11-toolkits/irrlicht/files/patch-source-Irrlicht_Makefile Thanks! |
Created attachment 148595 [details] patch-irrlicht.diff - apply NDEBUG=1 when DEBUG is off. - depend on libGL instead of libGLU. - add missing -lX11 -lz to LDFLAGS.