Bug 194567
| Summary: | [PATCH] sysutils/bsdadminscripts - distviper deletes all distfiles if /usr/ports is a symlink | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | rwmaillists | ||||||
| Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Some People | CC: | cjpm, pi | ||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Maintainers CC'd Created attachment 148676 [details]
bsdadminscripts.diff
Patch attached with your modification.
Thanks
poudriere tests look ok: http://people.freebsd.org/~pi/logs/sysutils__bsdadminscripts-10x-1414699332.txt http://people.freebsd.org/~pi/logs/sysutils__bsdadminscripts-91a-1414699332.txt http://people.freebsd.org/~pi/logs/sysutils__bsdadminscripts-84i-1414699332.txt kami: can you work on this ? A commit references this bug: Author: pi Date: Fri Nov 7 22:53:15 UTC 2014 New revision: 372302 URL: https://svnweb.freebsd.org/changeset/ports/372302 Log: sysutils/bsdadminscripts: fix distviper Adds a -H to all uses of find(1) in distviper so symlinks are handled correctly By default find(1) will not follow symlinks given on the command-line. There are several places in distviper where find is used without allowing for this. In particular in the default mode, if PORTSDIR is a link and DISTDIR isn't, then no distinfo files are found and all the distfiles are deleted. This can be fixed by either making sure that find is given directory names that end in a "/" or with the -H option. PR: 194567 Submitted by: rwmaillists@googlemail.com Approved by: Carlos Jacobo Puga Medina <cpm@fbsd.es> (maintainer) Changes: head/sysutils/bsdadminscripts/Makefile head/sysutils/bsdadminscripts/files/distviper.in head/sysutils/bsdadminscripts/pkg-plist Committed, thanks. |
Created attachment 148596 [details] Adds a -H to all uses of find(1) in distviper so symlinks are handled correctly By default find(1) will not follow symlinks given on the command-line. There are several places in distviper where find is used without allowing for this. In particular in the default mode, if PORTSDIR is a link and DISTDIR isn't, then no distinfo files are found and all the distfiles are deleted. This can be fixed by either making sure that find is given directory names that end in a "/" or with the -H option.