Bug 194602
| Summary: | [maintainer] Update astro/foxtrotgps to 1.2 | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | crwhipp |
| Component: | Individual Port(s) | Assignee: | Pawel Pekala <pawel> |
| Status: | Closed FIXED | ||
| Severity: | Affects Some People | CC: | pawel, wen |
| Priority: | --- | ||
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
| Attachments: | |||
Hi: Failed patch, would you fix ? Thanks ! wen make patch ===> License GPLv2 accepted by the user ===> foxtrotgps-1.2.0 depends on file: /usr/local/sbin/pkg - found ===> Fetching all distfiles required by foxtrotgps-1.2.0 for building ===> Extracting for foxtrotgps-1.2.0 => SHA256 Checksum OK for foxtrotgps-1.2.0.tar.gz. ===> Patching for foxtrotgps-1.2.0 ===> Applying FreeBSD patches for foxtrotgps-1.2.0 Ignoring previously applied (or reversed) patch. 2 out of 2 hunks ignored--saving rejects to src/main.c.rej => Patch patch-src-main failed to apply cleanly. *** Error code 1 Stop. make: stopped in /usr/ports/astro/foxtrotgps Created attachment 148815 [details]
updated patch
Updated patch.
apply via:
# cd /usr/ports/astro
# patch -E ${PATH_TO_PATCH}
These non-standard +++ / --- lines from git aren't too friendly. They can't be applied with svn patch although somebody can use "patch" with "-p" option. There's no proof via testing provided though. best: poudriere log with stage-qa checks enabled (attachment) acceptable: output from "portlint", "make check-plist", "make stage-qa" in an attachment. Created attachment 148898 [details]
svn diff to version 1.2
Created attachment 148899 [details]
poudriere testport log of build of new version
Alright - let's try this again. Attached is the poudriere testport log and the svn diff to create the new version. Part of this diff will remove the ./files subdirectory and its contents. Very nice! I'm promoting this PR to "patch-ready" status based on your new submissions. Hi, When you add optional documentation using %%PORTDOCS%% plist substitution you need to define DOCS option in port's Makefile: OPTIONS_DEFINE= DOCS so that user can see this option in port options dialog. Also why not all files installed in DOCSDIR are covered with PORTDOCS sub? This should be all files in DOCSDIR or none. Created attachment 149001 [details]
Updated patch, removes %%PORTDOCS%% from pkg-plist
Created attachment 149002 [details]
Updated poudriere testport log, with no %%PORTDOCS%% lines in pkg-plist.
(In reply to Pawel Pekala from comment #8) > Hi, > > When you add optional documentation using %%PORTDOCS%% plist substitution > you need to define DOCS option in port's Makefile: > > OPTIONS_DEFINE= DOCS > > so that user can see this option in port options dialog. > > Also why not all files installed in DOCSDIR are covered with PORTDOCS sub? > This should be all files in DOCSDIR or none. Submitted new patch and poudriere testport run log, with the %%PORTDOCS%% entries removed. A commit references this bug: Author: pawel Date: Tue Nov 4 15:00:46 UTC 2014 New revision: 372145 URL: https://svnweb.freebsd.org/changeset/ports/372145 Log: Update to version 1.2.0 PR: 194602 Submitted by: maintainer Changes: head/astro/foxtrotgps/Makefile head/astro/foxtrotgps/distinfo head/astro/foxtrotgps/files/ head/astro/foxtrotgps/pkg-plist |
Created attachment 148652 [details] Patch to bring port up to latest version. The latest version of FoxtrotGPS has been released. This patch brings the port, astro/foxtrotgps up to date. apply with: $ cd /usr/ports/astro/foxtrotgps $ patch < ${PATH_TO_PATCH} Updated port was tested with poudriere testport.