Bug 194732

Summary: AutoAssigner does not seem to run for some bug reports
Product: Services Reporter: Marcus von Appen <mva>
Component: Bug TrackerAssignee: Marcus von Appen <mva>
Status: Closed FIXED    
Severity: Affects Only Me CC: bugmeister, marino
Priority: ---    
Version: unspecified   
Hardware: Any   
OS: Any   

Description Marcus von Appen freebsd_committer freebsd_triage 2014-11-01 08:33:18 UTC
bug 194711 was not assigned/CC'd properly.

The logs do not reveal any problem with the autoassigner. 

Investigate locally.
Comment 1 Marcus von Appen freebsd_committer freebsd_triage 2014-11-01 17:32:38 UTC
I tried to recreate the behaviour with the contents of bug 194711, using a different input order (below). I was unable to reproduce that problem. It is there (as shown by the bug), but I can't reproduce it yet.

1) New Bug
2) Ports Tree / Individual Ports
3) Summary
4) Description
5) Attachment
6) Submit
Result: auto assignment works

1) New Bug
2) Ports Tree / Individual Ports
3) Attachment
4) Summary
5) Description
6) Submit
Result: auto assignment works

1) New Bug
2) Attachment
3) Summary
4) Description
5) Ports Tree / Individual Ports
6) Submit
Result: auto assignment works

1) New Bug
2) Ports Tree / Individual Ports
3) Description
4) Summary
5) Attachment
6) Submit
Result: auto assignment works

1) New Bug
2) Ports Tree / Individual Ports
3) Summary
4) Attachment
5) Description
6) Submit
Result: auto assignment works
Comment 2 John Marino freebsd_committer freebsd_triage 2014-11-19 09:50:58 UTC
It's not helpful at all to CC maintainers with @FreeBSD.org addresses.  They should be assigned the PR.

e.g. bug 195080

danfe@ was CC'd but it was left in triage.
PLEASE set it up to assign the PR to danfe@ (and open it).

I know you are against both but I can't figure out why and it's a huge PITA for triagers.  It makes the triage list a lot longer than it has to be and I just end up manually assigner the PR anyway.  Please see how the current behavior is not helpful.

Frankly I think CC'ing maintainer and leaving in triage is also very wrong but that discussion out of scope of this PR perhaps.
Comment 3 Marcus von Appen freebsd_committer freebsd_triage 2014-11-19 17:29:06 UTC
(In reply to John Marino from comment #2)
> It's not helpful at all to CC maintainers with @FreeBSD.org addresses.  They
> should be assigned the PR.
>
> e.g. bug 195080
> 
> danfe@ was CC'd but it was left in triage.
> PLEASE set it up to assign the PR to danfe@ (and open it).

The behaviour was correct, since the autoassigner found two ports being mentioned. It canät decide, which of the persons is in charge and hence does not reassign it (who knows, if the issue is caused by port foo or bar without a context analysis...).

> I know you are against both but I can't figure out why and it's a huge PITA
> for triagers.

The reason is explained above.

> It makes the triage list a lot longer than it has to be and I
> just end up manually assigner the PR anyway.  Please see how the current
> behavior is not helpful.

Understood. Question: how should we determine the *correct* maintainer, if multiple ports are mentioned? In my opinion, this is impossible.
We could however just pick the very first detected (whoever that is) and, if it is a @FreeBSD.org address, reassign.

What do you think?
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2014-12-17 12:16:50 UTC
Noticed while triaging that bug 196054 was not maintainer-cc'd
Comment 5 Marcus von Appen freebsd_committer freebsd_triage 2014-12-18 06:15:24 UTC
(In reply to Kubilay Kocak from comment #4)
> Noticed while triaging that bug 196054 was not maintainer-cc'd

According to its history, bug 196054 was filed in the wrong component. It's not a misbehaviour of the autoassigner.
Comment 6 Marcus von Appen freebsd_committer freebsd_triage 2015-02-28 19:56:55 UTC
No specific issues were mentioned anymore. I'll close this for now.