Bug 194767
| Summary: | [PATCH] sysutils/mcelog contains a patch adding code for an obsolete FreeBSD version | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | ftigeot | ||||||
| Component: | Individual Port(s) | Assignee: | John Marino <marino> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Many People | CC: | ftigeot, jdc, marino | ||||||
| Priority: | --- | Flags: | jdc:
maintainer-feedback+
|
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Maintainer CC'd Created attachment 148957 [details]
Patch relative to the port directory
The same change, as a diff relative to the existing version of the port.
Can you explain a bit as to how the getline() stub is causing a problem? Which version of FreeBSD are you using? Rephrased: I'm fine with removing the stub (FreeBSD 8.x was EOL'd 2014/04/30), but I'd like to know how it's causing problems on newer FreeBSD when the #if defined(__FreeBSD__) && __FreeBSD_version < 800067 shouldn't get applied to newer FreeBSD. Thank you! The getline() stub is not causing a problem on recent FreeBSD versions per se. Howewer, I'd like to build this port under DragonFly and adding -D__FreeBSD__ to CFLAGS would be the less invasive way to do that. Unfortunately, the getline() stub still requires additional handling. By removing it from the FreeBSD port, I will be able to reduce differences with the DragonFly version to a minimum. Understood. I'm fine with this patch replacing files/patch-config.c: https://bugs.freebsd.org/bugzilla/attachment.cgi?id=148951 Could someone with commit access please go ahead and commit that? (I don't know what the procedure is for this these days, since all the freebsd.org PR documentation still refers to the send-pr methodology and not Bugzilla). Also, committer: please remove http://mirror.be.gbxs.net/pub/linux/utils/cpu/mce/ from MASTER_SITES in the Makefile. That server doesn't respond on port 80 and hasn't for some time. I'll take it. A commit references this bug: Author: marino Date: Mon Nov 3 06:58:45 UTC 2014 New revision: 372095 URL: https://svnweb.freebsd.org/changeset/ports/372095 Log: sysutils/mcelog: Remove patch for unsupported versions of FreeBSD PR: 194767 Submitted by: Francois Tigeot Approved by: maintainer (Jeremy Chadwick) Changes: head/sysutils/mcelog/files/patch-config.c done, thanks! That was quick, thanks! |
Created attachment 148951 [details] New version of sysutils/mcelog/files/patch-config.c sysutils/mcelog contains a patch adding specific code for FreeBSD 8.0, files/patch-config.c I have attached a new version of this file removing the problematic code.