Bug 194794
| Summary: | [maintainer] [patch] www/otrs: make apache optional (for fastCGI setups, but Apache selected by default) | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | m.tsatsenko | ||||||
| Component: | Individual Port(s) | Assignee: | Bartek Rutkowski <robak> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | robak | ||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
This doesn't make it optional, it makes apache the default. You need to remove the "APACHE" option from defaults, right? (In reply to John Marino from comment #1) > This doesn't make it optional, it makes apache the default. > > You need to remove the "APACHE" option from defaults, right? Hi, John, Sorry for confusion. Actually I want to leave apache enabled by default and I have at least two reasons for that: 1) fastcgi is a little more tricky in comparison with apache+mod_perl 2) fastcgi is not (yet) officially supported by upstream On other hand I have received several requests to add an option to remove apache dependency. Okay, now it's clear. I tweaked the title and I'm promoting the PR. It looks ok to me. Hi, My tests of your patch are failing on pkg-plist here: http://pd.valinor.palantiri.org/data/11amd64-default/2014-11-21_12h35m42s/logs/errors/otrs-3.3.7.log Could you please review it and provide updated patch fixing these issues once you test it? Kind regards, Bartek Rutkowski Created attachment 149997 [details]
updated patch
Hi,
Thanks for feedback. I updated the patch correcting plist and I guess PORTREVISION bump is required now.
A commit references this bug: Author: robak Date: Mon Dec 1 14:18:10 UTC 2014 New revision: 373706 URL: https://svnweb.freebsd.org/changeset/ports/373706 Log: www/otrs: make Apache optional (but default) - Make apache and mod_perl optional (for fastCGI setups) - Clean up pkg-plist PR: 194794 Submitted by: Mikhail Tsatsenko <m.tsatsenko@gmail.com> Changes: head/www/otrs/Makefile head/www/otrs/pkg-plist Committed, thanks for your work! |
Created attachment 149006 [details] patch - Make apache and mod_perl optional (for fastCGI setups) - clean up plist