Bug 194849
| Summary: | [new port] science/mcstas-tools-p5: Perl base utility tools for the McStas Monte Carlo neutron ray tracing package | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Erik B Knudsen <erkn> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Rodrigo Osorio <rodrigo> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | CC: | rodrigo | ||||||||||
| Priority: | --- | ||||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 149278 [details]
McStas perl tools for McStas 2.1
Found a bug in the old archive - the pkg-descr was wrong.
still interested by madding this port ? Indeed I am. New to porting as I may be. cool. Created attachment 154115 [details]
p5-mcstas-tools port reworked
Hi, I found several flaws in your port ans try to fix it in the most elegant way. The port is not ready enough and extra work is required. For now : - I fix the port name to fulfill the naming style - I fix distfile management (fetch and extract) - I fix dependencies (for now I remove PDL, a really annoying one we will see in the future is PDL is really required or not) Todo: - After install we have broken symlinks (patch needed) - Test the port with real data Feel free to ask questions if you have, we are here to work together. (In reply to Rodrigo Osorio from comment #6) Hi, Thank you very much for editing and pointing out some deficiencies - my expressed aim is to make it as "standard" as possible. For sure I have made some beginners mistakes. Regarding PDL. It is indeed needed. If not some of the tools included in this port will not work. It is annoying, agreed. but unfortunately still necessary. Question: I notice you have moved some tar-logic from post-fetch to do-extract and rewritten it.I see that it is an extraction step and so logically should be in the extract section, is there some practical reason to have it there as opposed to the way it was before. I am probably missing something simple here. Otherwise I will go ahead and do some more work and testing on the port so that it gets up to par. Again thanks for the edits and comments cheers Erik (In reply to Erik B Knudsen from comment #7) Hi, sorry for the delay. In fact I rewrote the fetch extract process cause it was done the wrong way. We don't use to perform files manipulation in the DISTFILE dir ; we have the word dir, so use it. I also can argue that some variables were misused, making the makefile too complex. My last comment is: don't add comments on Makefiles, most of the time the code is auto-descriptive. Feel free to contact me if you need a review This PR is opened for a long time, let me know if you need time or any help porting the tool. regards - rodrigo (In reply to Rodrigo Osorio from comment #9) I'll need a bit more time - I've been away on leave for a while and so could not work on this. cheers Erik Created attachment 162704 [details]
New reworked version incl upgrade to mcstas 2.2a
New version following advice by R. Osorio.
The Makefile has been simplified.
pkg-install moved to files/ to allow portversion to be inherited, as McStas by default installs to PREFIX/mcstas/VERSION/...
The McStas team have been persuaded to not bundle everything in a single tarball
avoiding involved unpacking.
Furthermore - now tracking the latest version of McStas - 2.2a
last version looks fine, I still testing. A commit references this bug: Author: rodrigo Date: Fri Nov 20 23:34:40 UTC 2015 New revision: 402111 URL: https://svnweb.freebsd.org/changeset/ports/402111 Log: Add new port p5-Mcstas-Tools, a general tool for simulating neutron scattering instruments and experiments PR: 194849 Submitted by: Erik B Knudsen <erkn@fysik.dtu.dk> Changes: head/science/Makefile head/science/p5-Mcstas-Tools/ head/science/p5-Mcstas-Tools/Makefile head/science/p5-Mcstas-Tools/distinfo head/science/p5-Mcstas-Tools/files/ head/science/p5-Mcstas-Tools/files/pkg-install.in head/science/p5-Mcstas-Tools/pkg-descr head/science/p5-Mcstas-Tools/pkg-plist Committed with minor changes, thanks |
Created attachment 149105 [details] The McStas 2.1 perl tools During the upgrade to McStas 2.1 it was decide to split the port in kernel components and tools. The is the perl version of the utility tools