Bug 194862

Summary: editors/emacs failes to build if ALSA option enabled.
Product: Ports & Packages Reporter: SASAKI Katuhiro <crest>
Component: Individual Port(s)Assignee: Ashish SHUKLA <ashish>
Status: Closed FIXED    
Severity: Affects Some People Flags: crest: maintainer-feedback? (ashish)
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch for editors/emacs none

Description SASAKI Katuhiro 2014-11-06 10:27:06 UTC
Created attachment 149125 [details]
Patch for editors/emacs

If new ALSA option enabled, editors/emacs fails to build, because dependence on audio/alsa-lib is not written in Makefile.

% cd /usr/ports/editors/emacs
% sudo make
...
checking for alsa >= 1.0.0... no
configure: error: ALSA sound support requested but not found.
===>  Script "configure" failed unexpectedly.
Please report the problem to ashish@FreeBSD.org [maintainer] and attach the
"/var/portbuild/usr/ports/editors/emacs/work/emacs-24.4/config.log" including
the output of the failure of your make command. Also, it might be a good idea
to provide an overview of all packages installed on your system (e.g. a
/usr/local/sbin/pkg-static info -g -Ea).
*** Error code 1

Stop.
make[1]: stopped in /usr/ports/editors/emacs
*** Error code 1

Stop.
make: stopped in /usr/ports/editors/emacs

Adding next line is needed for alsa support.
ALSA_LIB_DEPENDS=	libasound.so:${PORTSDIR}/audio/alsa-lib
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-11-06 10:27:06 UTC
Auto-assigned to maintainer ashish@FreeBSD.org
Comment 2 Ashish SHUKLA freebsd_committer freebsd_triage 2014-11-06 14:31:22 UTC
(In reply to crest from comment #0)
> Created attachment 149125 [details]
> Patch for editors/emacs
> 
> If new ALSA option enabled, editors/emacs fails to build, because dependence
> on audio/alsa-lib is not written in Makefile.
> 
> % cd /usr/ports/editors/emacs
> % sudo make
> ...
> checking for alsa >= 1.0.0... no
> configure: error: ALSA sound support requested but not found.
> ===>  Script "configure" failed unexpectedly.
> Please report the problem to ashish@FreeBSD.org [maintainer] and attach the
> "/var/portbuild/usr/ports/editors/emacs/work/emacs-24.4/config.log" including
> the output of the failure of your make command. Also, it might be a good idea
> to provide an overview of all packages installed on your system (e.g. a
> /usr/local/sbin/pkg-static info -g -Ea).
> *** Error code 1
> 
> Stop.
> make[1]: stopped in /usr/ports/editors/emacs
> *** Error code 1
> 
> Stop.
> make: stopped in /usr/ports/editors/emacs
> 
> Adding next line is needed for alsa support.
> ALSA_LIB_DEPENDS=	libasound.so:${PORTSDIR}/audio/alsa-lib

Howdy,

Sorry about this. I'll commit a fix along with fix for couple of other issues discovered later, by tomorrow hopefully.

Thanks,
Ashish
Comment 3 Ashish SHUKLA freebsd_committer freebsd_triage 2014-11-07 12:54:48 UTC
Fix committed in r372258[1], and r372259[2].

[1] http://svnweb.freebsd.org/ports?view=revision&revision=372258
[2] http://svnweb.freebsd.org/ports?view=revision&revision=372259

Thanks!
Comment 4 Ashish SHUKLA freebsd_committer freebsd_triage 2014-12-28 17:05:53 UTC
Fixed sometime ago.