Bug 194944

Summary: [New port]: databases/hyperleveldb
Product: Ports & Packages Reporter: cheffo
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed Feedback Timeout    
Severity: Affects Some People CC: cheffo, marino, pawel
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
hyperleveldb port shar file
none
poudriere testport output
none
poudriere testport portlint output none

Description cheffo 2014-11-11 13:30:44 UTC 
Created attachment 149281 [details]
hyperleveldb port shar file

This is a new port of hyperleveldb - fork of leveldb.

HyperLevelDB is the data storage engine that powers HyperDex.
We forked HyperLevelDB from Google's LevelDB and adapted it to more closely
meet the needs of HyperDex.

HyperLevelDB improves on LevelDB in two key ways:

1: Improved parallelism: HyperLevelDB uses more fine-grained locking internally
to provide higher throughput for multiple writer threads.
2: Improved compaction: HyperLevelDB uses a different method of compaction that
achieves higher throughput for write-heavy workloads, even as the database
grows.

WWW: http://hyperdex.org/performance/leveldb/
WWW: https://github.com/rescrv/HyperLevelDB


redport logs - https://redports.org/buildarchive/20141111124848-98919/
Comment 1 cheffo 2014-11-11 13:31:33 UTC 
Created attachment 149282 [details]
poudriere testport output
Comment 2 cheffo 2014-11-11 13:31:58 UTC 
Created attachment 149283 [details]
poudriere testport portlint output
Comment 3 Pawel Pekala freebsd_committer freebsd_triage 2014-12-30 18:17:34 UTC 
Few things needs to be fixed:

- Overall Makefile declaration order needs reordering, after LICENSE, there
should be GITHUB_* block, then USE_ variables, on the end options declarations,
see other ports for correct ordering

- Lines should be broken around 80 characters for easier reading

> .include <bsd.port.options.mk>

Not needed, you do have any options dependent logic later

>        ${FIND} ${FIND_FILES}  | ${XARGS} -0 ${REINPLACE_CMD} -e 's|leveldb|hyperleveldb|g'
        ${FIND} ${FIND_FILES}  | ${XARGS} -0 ${REINPLACE_CMD} -e >'s|hyperhyperleveldb|hyperlev

This could be converted in one find execution and reinplace_cmd with two -e arguments. Making things simple is always better.

Usually post-patch targets silent their output with leading @ also.

> @dir include/hyperleveldb

Not needed, pkg handles automatically directories with files in them,
see /usr/ports/CHANGES entry 20140922 for details.
Comment 4 Pawel Pekala freebsd_committer freebsd_triage 2014-12-30 19:17:59 UTC 
One more thing:

XPORTNAME=	HyperLevelDB

Please don't use capital letters in port names.
Comment 5 John Marino freebsd_committer freebsd_triage 2015-05-17 15:37:16 UTC 
submission was not updated after feedback; more than 5 months have passed.  closing...