Bug 195095
| Summary: | sysutils/fusefs-kmod fails to build | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | woot-woot | ||||
| Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | dave, dpejesh, evgeni.dimitrov, riggs | ||||
| Priority: | --- | Keywords: | patch-ready | ||||
| Version: | Latest | Flags: | dpejesh:
maintainer-feedback+
|
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
|
Description
woot-woot
2014-11-17 09:17:56 UTC
Maintainer CC'd Created attachment 150099 [details] sysutils_fusefs-kmod.patch This port broke with r273912 [1] in base. A quick search in base/head revealed [2] and [3] which fix the port on 9-STABLE >= r273912. Unfortunately those patches break the port on 9-STABLE < r273912 and cannot be conditionally applied based on OSVERSION because it was not bumped with that revision. Taking that into account I modified the patches to conditionally compile the changes if the system supports it by checking if the new macros in <sys/sysctl.h> are defined. I also took the liberty of combining my changes with existing patches and updating the port's Makefile appropriately. The result is in the attached file. [1] https://svnweb.freebsd.org/base?view=revision&revision=273912 [2] https://svnweb.freebsd.org/base/head/sys/fs/fuse/fuse_main.c?r1=241519&r2=273377&view=patch [3] https://svnweb.freebsd.org/base/head/sys/fs/fuse/fuse_vfsops.c?r1=263233&r2=273377&view=patch Thanks for patch, works great. This patch worked perfectly for me. Could this please be merged into the ports tree? The port has a new maintainer (the old one timed out a few times). What does the maintainer say about all this? (dpejesh@yahoo.com) Patch looks good. Just need to bump the PORTREVISION on it. Tested on 9.2 amd64/i386 and 9.3 amd64/i386. promote to patch-ready status with a request to bump PORTREVISION. Reviewed and approved by the maintainer. A commit references this bug: Author: riggs Date: Mon Jan 26 18:57:58 UTC 2015 New revision: 377941 URL: https://svnweb.freebsd.org/changeset/ports/377941 Log: Fix build failure on 9.x While on it: - Pet portlint PR: 195095 Submitted by: woot-woot@yandex.ru (PR) evgeni.dimitrov@gmail.com (patch) Reviewed by: dpejesh@yahoo.com (maintainer) Approved by: dpejesh@yahoo.com (maintainer) MFH: 2015Q1 Changes: head/sysutils/fusefs-kmod/Makefile head/sysutils/fusefs-kmod/files/extra-patch-9-fuse_main.c head/sysutils/fusefs-kmod/files/extra-patch-9-fuse_vfsops.c head/sysutils/fusefs-kmod/pkg-descr A commit references this bug: Author: riggs Date: Tue Jan 27 20:29:20 UTC 2015 New revision: 378014 URL: https://svnweb.freebsd.org/changeset/ports/378014 Log: MFH: r377941 Fix build failure on 9.x While on it: - Pet portlint PR: 195095 Submitted by: woot-woot@yandex.ru (PR) evgeni.dimitrov@gmail.com (patch) Reviewed by: dpejesh@yahoo.com (maintainer) Approved by: portmgr (mat), dpejesh@yahoo.com (maintainer) Changes: _U branches/2015Q1/ branches/2015Q1/sysutils/fusefs-kmod/Makefile branches/2015Q1/sysutils/fusefs-kmod/files/extra-patch-9-fuse_main.c branches/2015Q1/sysutils/fusefs-kmod/files/extra-patch-9-fuse_vfsops.c branches/2015Q1/sysutils/fusefs-kmod/pkg-descr |
