Bug 195157
| Summary: | [PORT net-im/qTox] Maintainer update qTox-0.141118 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Yuri Victorovich <yuri> | ||||||
| Component: | Individual Port(s) | Assignee: | Thierry Thomas <thierry> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | thierry | ||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Created attachment 149571 [details]
pourfriere log
Please do not add a dependency on security/libsodium: Tox can be built with this option disabled and switched to NaCl.
To be sure, you could use ${LOCALBASE}/libdata/pkgconfig/libtoxcore.pc but anyway there is no need to add this indirect dependency.
qTox itself is currently inconsistent with libsodium being optional. It uses libsodium directly in main.cpp (sodium_init) and from autoupdate.cpp (crypto_sign_verify_detached), among other places. It will not build without this dependency when toxcore is built without SODIUM option. With it, it will at least (maybe) still work. I will file the problem report in qTox github asking to fix this. In the meantime, we probably should leave qTox with libsodium dependency. A commit references this bug: Author: thierry Date: Fri Nov 21 21:53:04 UTC 2014 New revision: 373016 URL: https://svnweb.freebsd.org/changeset/ports/373016 Log: Upgrading to 0.141118. Note: ATM qTox won't work if Tox has been built with the NACL option! PR: ports/195157 Submitted by: yuri (at) rawbw.com (maintainer) Changes: head/net-im/qTox/Makefile head/net-im/qTox/distinfo head/net-im/qTox/files/patch-qtox.pro |
Created attachment 149570 [details] patch