Bug 195366

Summary: Closing shouldn't require a comment
Product: Services Reporter: John Baldwin <jhb>
Component: Bug TrackerAssignee: Bugmeister <bugmeister>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: ---    
Version: unspecified   
Hardware: Any   
OS: Any   

Description John Baldwin freebsd_committer freebsd_triage 2014-11-25 12:50:41 UTC
Not all bugs require a comment when closing.  For an example, see 194828.  It is clear from the comment trail and the automatic note generated when the change was committed why it was appropriate to close the bug.  With other bug systems I've worked with, I would have annotated the commit message to auto-close the bug when the commit was made.  Having the commit count as the message for closing (and thus not requiring an explicit comment to close) would be sufficiently close.  Instead, what you will end up with is pointless comments (yesterday I saw dim@ cut and paste the error message "This must have a comment" to close a bug, and I just used "This is a comment").  I don't recall having to do this before now, so this appears to be a recent regression?  (Or at least, this is the first time I've run into this, and seeing the junk comment from dim@ yesterday makes it seem like not a purely isolated issue)
Comment 1 Marcus von Appen freebsd_committer freebsd_triage 2014-11-25 14:54:50 UTC
That was introduced by accident, when I refactored the status model. Apologies for that; it should be fixed now.
Comment 2 John Baldwin freebsd_committer freebsd_triage 2014-11-25 16:06:19 UTC
No problem, thanks for fixing so quickly!