Bug 195577
| Summary: | devel/jsoncpp: pass whole environment through SCons | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Dmitry Marakasov <amdmi3> | ||||
| Component: | Individual Port(s) | Assignee: | Dmitry Marakasov <amdmi3> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | johan | ||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(johan) |
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Maintainer CC'd I'm not too familiar with scons (haven't used it more than using it in this port), but I don't see any apparent problem, as long as it builds fine. Go ahead! A commit references this bug: Author: amdmi3 Date: Tue Dec 2 14:26:00 UTC 2014 New revision: 373763 URL: https://svnweb.freebsd.org/changeset/ports/373763 Log: - Prevent SCons from trimming environment PR: 195577 Submitted by: amdmi3 Approved by: johan@stromnet.se (maintainer) Changes: head/devel/jsoncpp/files/patch-SConstruct |
Created attachment 150093 [details] Proposed patch By default, SCons cleans environment it passes to child processes. This breaks build in certain cases - for example, when ccache is used and CCACHE_DIR is passed to set its cache directory (that is used by poudriere, for instance). Though upstream SConstruct passes some variables, this is not enough, so pass everything.