Bug 195654

Summary: net-im/qTox: add databases/qt5-sqldrivers-sqlite3 missing dependency
Product: Ports & Packages Reporter: Igor Ostapenko <igor.ostapenko>
Component: Individual Port(s)Assignee: Thierry Thomas <thierry>
Status: Closed FIXED    
Severity: Affects Only Me CC: kde, makc, thierry, yuri
Priority: --- Flags: thierry: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
qTox-0.141118.diff
none
updated patch
yuri: maintainer-approval-
poudriere log none

Description Igor Ostapenko 2014-12-03 20:55:46 UTC
Created attachment 150153 [details]
qTox-0.141118.diff

If devel/qt5 meta port is installed with default options then this driver will be around, otherwise qTox ends up be running w/o it, what leads to crashes upon posting/etc, i.e. when it tries to hit its *db files.
The attached patch example makes qTox happy w/o full devel/qt5.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-12-03 20:55:46 UTC
Maintainers CC'd
Comment 2 Thierry Thomas freebsd_committer freebsd_triage 2014-12-03 22:09:51 UTC
Waiting for maintainer's approval.
Comment 3 Max Brazhnikov freebsd_committer freebsd_triage 2014-12-03 22:43:49 UTC
Please add _run suffix to sql-sqlite3 and _build to linguisttools.
See http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/using-qt.html#qt-components for details.
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2014-12-04 01:51:13 UTC
Created attachment 150169 [details]
updated patch

Thanks Igor and Max, I integrated both suggestions into this 'updated patch'.
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2014-12-04 01:53:37 UTC
Created attachment 150170 [details]
poudriere log
Comment 6 Yuri Victorovich freebsd_committer freebsd_triage 2014-12-04 01:55:37 UTC
In pourdriere log, please ignore:

> ====> Running Q/A tests (stage-qa)
> Warning: dependency file /usr/local/lib/libGL.so.1 doesn't belong to any package

This is from the new test I have locally, not in the head.
Comment 7 commit-hook freebsd_committer freebsd_triage 2014-12-04 22:40:52 UTC
A commit references this bug:

Author: thierry
Date: Thu Dec  4 22:40:44 UTC 2014
New revision: 373988
URL: https://svnweb.freebsd.org/changeset/ports/373988

Log:
  Add databases/qt5-sqldrivers-sqlite3 missing dependency.

  PR:		ports/195654
  Submitted by:	Igor Ostapenko
  Approved by:	maintainer (yuri)

Changes:
  head/net-im/qTox/Makefile
Comment 8 Thierry Thomas freebsd_committer freebsd_triage 2014-12-04 22:41:16 UTC
Committed, thanks!